New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 884035 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Replace tools/perf/core/default_local_state.json with something automatic

Project Member Reported by csharrison@chromium.org, Sep 14

Issue description

We've added a checksum to the subresource_filter prefs. We need perf bots to use the right checksum.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8

commit 57a964a4f23aef1ced2036ce09217ca8bfc5d8f8
Author: Charlie Harrison <csharrison@chromium.org>
Date: Tue Sep 18 16:45:42 2018

Dynamically generate prefs in perf benchmarks

This CL deletes default_local_state.json used by perf bots in
favor of dynamically generating it via a compiled action step.

This JSON is used to populate prefs at startup, so ad tagging works
properly. Currently, we need to update it every time the format or
checksum of the ruleset changes. With this CL, this maintenance is
not longer needed. See  http://crbug.com/823982  for more context.

Bug:  884035 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ifaa112ffe25689051a9338ea40c21fe1f56abb78
Reviewed-on: https://chromium-review.googlesource.com/1226292
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592076}
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/core/common/PRESUBMIT.py
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/core/common/indexed_ruleset.cc
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/tools/BUILD.gn
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/tools/indexing_tool.cc
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/tools/indexing_tool.h
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/tools/indexing_tool_main.cc
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/components/subresource_filter/tools/indexing_tool_unittest.cc
[delete] https://crrev.com/b128541e6639618c3d18b2f8216b60dcf195d0ef/tools/perf/core/default_local_state.json
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/tools/perf/core/perf_benchmark.py
[modify] https://crrev.com/57a964a4f23aef1ced2036ce09217ca8bfc5d8f8/tools/perf/core/perf_benchmark_unittest.py

Owner: csharrison@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82137afcdcf93b1da6dd126d1dd4b64ee1002d8c

commit 82137afcdcf93b1da6dd126d1dd4b64ee1002d8c
Author: Charlie Harrison <csharrison@chromium.org>
Date: Wed Sep 19 14:37:28 2018

PerfBenchmark: Add test for invalid JSON prefs

These prefs are generated at compile-time. Currently, the perf benchmarks
will hard-fail if the JSON is invalid. This CL adds tests for that case.

Bug:  884035 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I58610eb69a4b2610dce72e6de2f8cba2104a29d6
Reviewed-on: https://chromium-review.googlesource.com/1231840
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592392}
[modify] https://crrev.com/82137afcdcf93b1da6dd126d1dd4b64ee1002d8c/tools/perf/core/perf_benchmark_unittest.py

Status: Fixed (was: Assigned)

Sign in to add a comment