New issue
Advanced search Search tips

Issue 884029 link

Starred by 6 users
Status: Fixed
Owner:
weili@chromium.org
Closed: Sep 19
Cc:
sdy@chromium.org
weili@chromium.org
phanindra.mandapaka@chromium.org
chrome-conops-escalation@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Toolbar does not reappear after leaving tab fullscreen

Reported by jleedev@gmail.com, Sep 13 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.16 Safari/537.36

Steps to reproduce the problem:
1. Enter fullscreen
2. Enter tab fullscreen
3. Press escape

What is the expected behavior?
Toolbar reappears

What went wrong?
Toolbar remains hidden until you move the mouse to the top of the screen

Did this work before? Yes 

Chrome version: 70.0.3538.16  Channel: beta
OS Version: OS X 10.13.6
Flash Version: 

You are probably looking for a change made after 589846 (known good), but no later than 589868 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/f57f5f8ee29f223cefee213a86a1542e50f04b8b..771206507ab469fe7a382befcf273c42ef3cc702

(To be clear, this includes the changes in  Issue 879158 )
Untitled.mov
2.3 MB View Download

Comment 1 by weili@chromium.org, Sep 14

Components: -UI UI>Browser>FullScreen
Owner: weili@chromium.org
Status: Started (was: Unconfirmed)
Thanks for the report, will fix it.

Comment 2 by craigtumblison@chromium.org, Sep 14

Labels: Hotlist-ConOps
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee9e842461581c366dbe744d577eba785e8dcbd5

commit ee9e842461581c366dbe744d577eba785e8dcbd5
Author: Wei Li <weili@chromium.org>
Date: Tue Sep 18 18:58:16 2018

Fix re-layout condition upon fullscreen style change

When Chrome's fullscreen toolbar style changes, it needs to re-layout to
make sure the UI is updated. This CL fixed a recent regression due to
using |is_exiting_fullscreen| to avoid re-layout. Instead, only when
Chrome exits fullscreen mode to non-fullscreen mode, we should avoid
doing re-layout because exiting tab fullscreen to browser fullscreen
still may requires a re-layout.

BUG= 884029 

Change-Id: I7392c2cb000b184c0f54b9cb6bb3de2b81a79dcf
Reviewed-on: https://chromium-review.googlesource.com/1226014
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592124}
[modify] https://crrev.com/ee9e842461581c366dbe744d577eba785e8dcbd5/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/ee9e842461581c366dbe744d577eba785e8dcbd5/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/ee9e842461581c366dbe744d577eba785e8dcbd5/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/ee9e842461581c366dbe744d577eba785e8dcbd5/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/ee9e842461581c366dbe744d577eba785e8dcbd5/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/ee9e842461581c366dbe744d577eba785e8dcbd5/chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc

Comment 4 by weili@chromium.org, Sep 19

Status: Fixed (was: Started)

Comment 5 by weili@chromium.org, Oct 29

Cc: sdy@chromium.org weili@chromium.org
 Issue 899743  has been merged into this issue.

Comment 6 by sdy@chromium.org, Nov 2

Cc: phanindra.mandapaka@chromium.org
 Issue 901122  has been merged into this issue.
►

Sign in to add a comment