The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b216c82bca44937f63aa705968ee42d18cd06d09

commit b216c82bca44937f63aa705968ee42d18cd06d09
Author: Stuart Langley <slangley@google.com>
Date: Tue Sep 18 10:54:07 2018

Add VolumeManager root types COMPUTERS_GRAND_ROOT and COMPUTER.

DriveFS supports exposing the computers that a user has enrolled in Backup and
Sync under the drive root, something like:

+ Drive Root
-+ My Drive
--+ Sub Folder 1
-+ Team Drives
--+ Team Drive 1
-+ Computers
--+ My Macbook 1
--+ My Macbook 2

This change introduces the new root types to support "Computers" and child
entries that represent each computer.

Added unit tests in volume_manager_unittests and code required to have the unit
tests pass. Mostly by cargo culting how team drives works.

https://www.google.com/drive/download/backup-and-sync/

Bug:  884020 
Change-Id: I7371ebfbdca6ca1d1c4fa2bcb2d6707067b112e6
Reviewed-on: https://chromium-review.googlesource.com/1229718
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591994}
[modify] https://crrev.com/b216c82bca44937f63aa705968ee42d18cd06d09/ui/file_manager/file_manager/background/js/entry_location_impl.js
[modify] https://crrev.com/b216c82bca44937f63aa705968ee42d18cd06d09/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/b216c82bca44937f63aa705968ee42d18cd06d09/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/b216c82bca44937f63aa705968ee42d18cd06d09/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
[modify] https://crrev.com/b216c82bca44937f63aa705968ee42d18cd06d09/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/b216c82bca44937f63aa705968ee42d18cd06d09/ui/file_manager/file_manager/common/js/volume_manager_common.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55e6e6c77d46f8c204efa8ca46a5ea83d7511e35

commit 55e6e6c77d46f8c204efa8ca46a5ea83d7511e35
Author: Stuart Langley <slangley@google.com>
Date: Fri Sep 21 03:49:05 2018

Add drive/Computers to ResourceMetadata.

This adds a "drive/Computers" folder to ResourceMetadata, so that we should
always have a valid path for the top level Computers folder regardless of the
sync engine being used.

This makes it easier on the UI side as we do not need to special case any
handling for sync engine, and if we do not find a "drive/Computers" path than
we can treat it as a real error.

Bug:  884020 
Change-Id: Ib30e65a00f7e9e62ceb89b47715f591ffba9e041
Reviewed-on: https://chromium-review.googlesource.com/1237016
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593072}
[modify] https://crrev.com/55e6e6c77d46f8c204efa8ca46a5ea83d7511e35/components/drive/chromeos/resource_metadata.cc
[modify] https://crrev.com/55e6e6c77d46f8c204efa8ca46a5ea83d7511e35/components/drive/file_system_core_util.h
[modify] https://crrev.com/55e6e6c77d46f8c204efa8ca46a5ea83d7511e35/components/drive/file_system_unittest.cc
[modify] https://crrev.com/55e6e6c77d46f8c204efa8ca46a5ea83d7511e35/components/drive/resource_metadata_unittest.cc

Move to 72 to align with DriveFS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/867c55d7091f2ed5ff3ccc6d332b14d543e7a810

commit 867c55d7091f2ed5ff3ccc6d332b14d543e7a810
Author: Stuart Langley <slangley@google.com>
Date: Thu Oct 18 03:26:36 2018

Add a directory entry for "Computers" in the directory tree.

Add support for /drive/Computers in volume_info and directory_tree,
for displaying a users backed up Computers, if they have any. The
logic here is very similar to the logic for team drives, where we will
only display the '/Computers' entry if there is a sub-directory under
it. Hence a lot of the code is cargo culted from the team drives
implementation.

Potentially come back and refactor the common code between Computers
and Team Drives once this stabilizes.

Bug:  884020 
Change-Id: I1ebf52ba64e5cb5bd809b64cc52bf182e3d11f19
Reviewed-on: https://chromium-review.googlesource.com/c/1255084
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600650}
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/chrome/app/file_manager_strings.grdp
[add] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_DRIVE_COMPUTERS_LABEL.png.sha1
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/externs/volume_info.js
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/file_manager/background/js/entry_location_impl.js
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
[modify] https://crrev.com/867c55d7091f2ed5ff3ccc6d332b14d543e7a810/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d44fb8f1bba0671a9ea4b02e8bd41fd2e0b63c8

commit 5d44fb8f1bba0671a9ea4b02e8bd41fd2e0b63c8
Author: Stuart Langley <slangley@google.com>
Date: Fri Oct 19 02:56:38 2018

Add support for drive/Computers to PathUtil.

This ensures that the correctly localized name is displayed in settings for the
drive/Computers path.

Bug:  884020 
Change-Id: Iaa68242aba57d0ac2228d6b90a6c627f5757875e
Reviewed-on: https://chromium-review.googlesource.com/c/1290489
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601035}
[modify] https://crrev.com/5d44fb8f1bba0671a9ea4b02e8bd41fd2e0b63c8/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/5d44fb8f1bba0671a9ea4b02e8bd41fd2e0b63c8/chrome/browser/chromeos/file_manager/path_util.h
[modify] https://crrev.com/5d44fb8f1bba0671a9ea4b02e8bd41fd2e0b63c8/chrome/browser/chromeos/file_manager/path_util_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1321863c71871f6b7a90145a5aa0aafb8a1f5e28

commit 1321863c71871f6b7a90145a5aa0aafb8a1f5e28
Author: Stuart Langley <slangley@google.com>
Date: Fri Nov 02 00:01:43 2018

Fix breadcrumbs for "Computers" and nested computers.

This patch updates line_location.js to support deciphering paths that fall
under Google Drive > Computers.

Adds an integration test which ensures that Computers entries can be navigated,
which has the side effect of also testing that the breadcrumbs are working as
breadcrumbs are used to work out where the navigation has actually navigated to.

Bug:  884020 
Change-Id: I8ea14eb6716a5060005442e65d07125b41a9c4a3
Reviewed-on: https://chromium-review.googlesource.com/c/1312178
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604761}
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/ui/file_manager/file_manager/foreground/js/ui/location_line.js
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/ui/file_manager/file_manager/test/js/test_util.js
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/ui/file_manager/integration_tests/file_manager/background.js
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/ui/file_manager/integration_tests/file_manager/file_display.js
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/ui/file_manager/integration_tests/remote_call.js
[modify] https://crrev.com/1321863c71871f6b7a90145a5aa0aafb8a1f5e28/ui/file_manager/integration_tests/test_util.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e6edb882447e263323bd30e959ebbd37a7bf9b5

commit 6e6edb882447e263323bd30e959ebbd37a7bf9b5
Author: Stuart Langley <slangley@google.com>
Date: Fri Nov 02 05:13:31 2018

Initial wire up of icons for "Computers" section of Google Drive.

We're still waiting on the correct artwork, so for now just re-use existing
icons so we get the feature working.

Still needs to support "USB and External Devices" after confirming with
drive folks that this name will not be localized.

Tested manually as there are no automated tests for style right now.

Bug:  884020 
Change-Id: I209f6e1a76c75655475e4c62ee6e97f79c9215df
Reviewed-on: https://chromium-review.googlesource.com/c/1313988
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604846}
[modify] https://crrev.com/6e6edb882447e263323bd30e959ebbd37a7bf9b5/ui/file_manager/file_manager/foreground/css/file_types.css
[modify] https://crrev.com/6e6edb882447e263323bd30e959ebbd37a7bf9b5/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/6e6edb882447e263323bd30e959ebbd37a7bf9b5/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c4c3fecc4e1fbb4c12ef4cd5ee24616759d2afa

commit 8c4c3fecc4e1fbb4c12ef4cd5ee24616759d2afa
Author: Stuart Langley <slangley@google.com>
Date: Wed Nov 07 03:56:35 2018

Added mojo changes for supporting drivefs folder_features to chromium.

This brings across the changes made inside chromeos to the mojom that is
defined in chromium.

Bug:  884020 
Change-Id: Iab4d789cf153fabbf8d243fd346e2188e9c4153b
Reviewed-on: https://chromium-review.googlesource.com/c/1321652
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605952}
[modify] https://crrev.com/8c4c3fecc4e1fbb4c12ef4cd5ee24616759d2afa/chromeos/components/drivefs/mojom/drivefs.mojom

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9c4c9f948ed0b2d41601f050c8e75c6f7d174cc

commit c9c4c9f948ed0b2d41601f050c8e75c6f7d174cc
Author: Stuart Langley <slangley@google.com>
Date: Wed Nov 07 10:25:45 2018

Make TestEntryInfo more user friendly by not having a googol of ctor args.

Preparation for adding FolderFeatures as another parameter that can be
set on a TestEntryInfo object.

Bug:  884020 
Change-Id: I1fec6cc38f024df83b5b3c065f1b6ec5e8462347
Reviewed-on: https://chromium-review.googlesource.com/c/1322341
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606008}
[modify] https://crrev.com/c9c4c9f948ed0b2d41601f050c8e75c6f7d174cc/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/drivefs/+/f1f8ab22bfddb23f17ec5d1a3118c3c266a2f3ad

commit f1f8ab22bfddb23f17ec5d1a3118c3c266a2f3ad
Author: Stuart Langley <slangley@google.com>
Date: Thu Nov 08 04:27:31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab6f59e341933fa5e8b2df833e0464176a6fb7e0

commit ab6f59e341933fa5e8b2df833e0464176a6fb7e0
Author: Stuart Langley <slangley@google.com>
Date: Fri Nov 09 07:50:07 2018

Wire FolderFeature into file manager private_api and browser tests.

- Fixes the spelling of "arbitrary" in the mojom.
- Adds the fields specified in FolderFeature to EntryProperties
  so they are accessible from the app.
- Updates the browser test code and fake_drivefs to support
  setting FolderFeature values in an entry.

Bug:  884020 
Change-Id: Ica46d66478e7352724454426a9306f8a447c1c55
Reviewed-on: https://chromium-review.googlesource.com/c/1322337
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606762}
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/chromeos/components/drivefs/fake_drivefs.cc
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/chromeos/components/drivefs/fake_drivefs.h
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/chromeos/components/drivefs/mojom/drivefs.mojom
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/ab6f59e341933fa5e8b2df833e0464176a6fb7e0/ui/file_manager/integration_tests/test_util.js

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/platform/drivefs/+/2acc9e66c3f26e15d9ded23220afd71a15c96da7

commit 2acc9e66c3f26e15d9ded23220afd71a15c96da7
Author: Stuart Langley <slangley@google.com>
Date: Fri Nov 16 23:10:58 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f

commit 36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f
Author: Stuart Langley <slangley@google.com>
Date: Sun Nov 18 23:27:24 2018

Introduce icons for computers grand root, computes and external devices.

This CL introduces the new icons for the Computers grand root and the
computers located under it. It re-uses the USB icon for "USB and
External Devices".

Plumb through the required metadata so we can work out if an entry
is a machine root or a external media root, so we can show the
different icons. Add a test for this.

TODO: Get the USB icon to correctly show in the left hand directory
tree. I thought this CL was big enough without including that followup
fix.

Bug:  884020 
Change-Id: I95151444b65f1c0fd680b761fcaa6190105d8fbf
Reviewed-on: https://chromium-review.googlesource.com/c/1338581
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609154}
[modify] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/css/file_types.css
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/2x/computer.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/2x/computer_active.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/2x/devices.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/2x/devices_active.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/computer.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/computer_active.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/devices.png
[add] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/images/volumes/devices_active.png
[modify] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
[modify] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.js
[modify] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/36cbe46fb26a3bbfb9bee0d73e5d75c2d269959f/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509923f0390c24617a433c87fe4a3c1f2853d10c

commit 509923f0390c24617a433c87fe4a3c1f2853d10c
Author: Stuart Langley <slangley@google.com>
Date: Wed Nov 28 23:25:44 2018

Update to the final icons for the "Devices" and "Computers" volumes.

Bug:  884020 
Change-Id: I072b6902757149f93bbf40443e45b56670b04858
Reviewed-on: https://chromium-review.googlesource.com/c/1350410
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611931}
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/2x/computer.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/2x/computer_active.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/2x/devices.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/2x/devices_active.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/computer.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/computer_active.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/devices.png
[modify] https://crrev.com/509923f0390c24617a433c87fe4a3c1f2853d10c/ui/file_manager/file_manager/foreground/images/volumes/devices_active.png

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adefd8b25a35a810a19c284f81a1976a05801749

commit adefd8b25a35a810a19c284f81a1976a05801749
Author: Stuart Langley <slangley@google.com>
Date: Tue Dec 04 05:09:43 2018

Show the USB icon for external media roots in Computers.

Bug:  884020 
Change-Id: I056a5a830c8ca5821d6ca3338372ee27702c0ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1355308
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613421}
[modify] https://crrev.com/adefd8b25a35a810a19c284f81a1976a05801749/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/adefd8b25a35a810a19c284f81a1976a05801749/ui/file_manager/base/js/volume_manager_types.js
[modify] https://crrev.com/adefd8b25a35a810a19c284f81a1976a05801749/ui/file_manager/file_manager/foreground/css/file_types.css
[modify] https://crrev.com/adefd8b25a35a810a19c284f81a1976a05801749/ui/file_manager/file_manager/foreground/js/constants.js
[modify] https://crrev.com/adefd8b25a35a810a19c284f81a1976a05801749/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cecdfb8434e863216708ac6d03ee5a1df9b6db2

commit 8cecdfb8434e863216708ac6d03ee5a1df9b6db2
Author: Stuart Langley <slangley@google.com>
Date: Wed Dec 05 01:51:39 2018

Show the USB icon for external media roots in Computers.

Bug:  884020 
Change-Id: I056a5a830c8ca5821d6ca3338372ee27702c0ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1355308
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613421}(cherry picked from commit adefd8b25a35a810a19c284f81a1976a05801749)
Reviewed-on: https://chromium-review.googlesource.com/c/1362487
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#64}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/8cecdfb8434e863216708ac6d03ee5a1df9b6db2/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/8cecdfb8434e863216708ac6d03ee5a1df9b6db2/ui/file_manager/base/js/volume_manager_types.js
[modify] https://crrev.com/8cecdfb8434e863216708ac6d03ee5a1df9b6db2/ui/file_manager/file_manager/foreground/css/file_types.css
[modify] https://crrev.com/8cecdfb8434e863216708ac6d03ee5a1df9b6db2/ui/file_manager/file_manager/foreground/js/constants.js
[modify] https://crrev.com/8cecdfb8434e863216708ac6d03ee5a1df9b6db2/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

This bug requires manual review: There is .grd file changes and we are only 54 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This was already merged ... 

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 8cecdfb8434e863216708ac6d03ee5a1df9b6db2 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/8cecdfb8434e863216708ac6d03ee5a1df9b6db2

Commit: 8cecdfb8434e863216708ac6d03ee5a1df9b6db2
Author: slangley@google.com
Commiter: slangley@chromium.org
Date: 2018-12-05 01:51:39 +0000 UTC

Show the USB icon for external media roots in Computers.

Bug:  884020 
Change-Id: I056a5a830c8ca5821d6ca3338372ee27702c0ff9
Reviewed-on: https://chromium-review.googlesource.com/c/1355308
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613421}(cherry picked from commit adefd8b25a35a810a19c284f81a1976a05801749)
Reviewed-on: https://chromium-review.googlesource.com/c/1362487
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#64}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}