New issue
Advanced search Search tips

Issue 884008 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Merge Request M70] Card Migration Dialog Simple Fix

Project Member Reported by siyua@chromium.org, Sep 13

Issue description

Requesting to merge some simple fix for card migration dialog.

https://chromium-review.googlesource.com/c/chromium/src/+/1218462

Have manually tested in Canary successfully. The whole flow is protected by Finch flag.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 13

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Hotlist-Paradise
Labels: -Merge-Review-70 Merge-Approved-70
branch:3538
Status: Fixed (was: Assigned)
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1225885.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73f51f41555d3c5968200cd317b64d80bce1ae36

commit 73f51f41555d3c5968200cd317b64d80bce1ae36
Author: siyua <siyua@chromium.org>
Date: Fri Sep 14 18:12:46 2018

Some Simple Fix to Resolve the remaining comments in CL 1192688

There are some comments from Bret(bsep@) regarding the migration dialog
view.

1) Change the names of some file local constants.
2) Change dialog view member to pointers.
3) Change label initialization in view util.
4) Add a comment for feature kAutofillLocalCardMigrationShowFeedback.

Bug:  884008 
Change-Id: I5a1f0e3637415d39bd4b602c69a30adcfd2916c5
Reviewed-on: https://chromium-review.googlesource.com/1218462
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590796}(cherry picked from commit c654cafbca9ee25ab8dd15dc1dee8ce8b48971cb)
Reviewed-on: https://chromium-review.googlesource.com/1225885
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3538@{#409}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/73f51f41555d3c5968200cd317b64d80bce1ae36/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
[modify] https://crrev.com/73f51f41555d3c5968200cd317b64d80bce1ae36/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
[modify] https://crrev.com/73f51f41555d3c5968200cd317b64d80bce1ae36/chrome/browser/ui/views/autofill/view_util.cc
[modify] https://crrev.com/73f51f41555d3c5968200cd317b64d80bce1ae36/components/autofill/core/common/autofill_features.cc

siyua@,
Please provide us clear steps to verify this issue from TE end as per the fix in C#5.
Thanks..!
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Hi jmukthavaram@,

Please refer to the test plan go/ib-paradise-test-plan.

This does not fix any particular bug/issue, but does some code refinement.

If the whole flow works as expected then this CL should works fine as well.

Sign in to add a comment