New issue
Advanced search Search tips

Issue 883987 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add New Person: Cannot select all (Cmd+A) in name field

Project Member Reported by rsesek@chromium.org, Sep 13

Issue description

Chrome Version: 71.0.3551.0
OS: macOS 10.13.5

What steps will reproduce the problem?
(1) Click on the profile button in the toolbar
(2) Click Manage People
(3) Click the Add Person button
(4) With the cursor in the new person's name field, try pressing Cmd+A to select all text

What is the expected result?
All of the text in the field is selected.

What happens instead?
Cmd+A does not select the text in the field

Something is probably eating the key event.

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Cc: erikc...@chromium.org
NSMenu access isn't plumbed through for this widget :/. It's not a Browser* and has no parent window in order to find a Browser*, but it *is* a renderer. The renderer is going to suppress the normal event handling - normally things then go through an override of WebContentsDelegate::HandleKeyboardEvent() (e.g. BrowserFrameMac's or ExtensionViewHost's or DevToolsToolboxDelegate's or WebUILoginView's, etc.)

but UserManagerProfileDialogDelegate doesn't override this - keyboard events the renderer doesn't consume are just gonna get dropped on the floor.

There's no views UI in the window... as an interim solution, we could just remove the IsViewsBrowserCocoa check from

void UserManager::Show(
    const base::FilePath& profile_path_to_focus,
    profiles::UserManagerAction user_manager_action) {
#if defined(OS_MACOSX)
  if (views_mode_controller::IsViewsBrowserCocoa()) {
    return UserManager::ShowCocoa(profile_path_to_focus, user_manager_action);
  }
#endif

but probably UserManagerProfileDialogDelegate just needs a views::UnhandledKeyboardEventHandler data member to handle the event so that it ends up in

// static
void UnhandledKeyboardEventHandler::HandleNativeKeyboardEvent(
    gfx::NativeEvent event,
    FocusManager* focus_manager) {
  [[base::mac::ObjCCastStrict<NativeWidgetMacNSWindow>([event window])
      commandDispatcher] redispatchKeyEvent:event];
}

Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to erikchen@chromium.org per suggestion from tapted@.
Owner: ----
Status: Untriaged (was: Assigned)
Status: Available (was: Untriaged)
Labels: MacViews-Controls MacViews-Dialogs Proj-MacViews

Sign in to add a comment