Require a "Reason for revert" in Gerrit |
|||
Issue descriptionI didn't know if this would be better as a Gerrit bug or a Chromium git policy bug, so starting here. Frequently I see people reverting CLs without specifying a reason for the revert. The reason is really important, especially if the CL was reverted in your non-working-hours. Gerrit by default sets the reason to "<INSERT REASONING HERE>" which people often just leave as-is, as evinced by: % git log --grep='<INSERT REASONING HERE>' If I catch it, I leave a comment on the CL description asking for it to be updated. But could we instead not have the placeholder text, and then make a reason string required before creating the revert?
,
Oct 1
It doesn't look like this is in Chrome's chromium-behavior Gerrit plugin that does modify revert behavior. Tou can find the '<INSERT REASONING HERE>' template easily in Gerrit source. I've filed http://b/117118644 with Gerrit team to track this request. Though they are extremely busy so I don't expect quick prioritization of such an enhancement. They would probably accept contributions, or someone might be able to enhance our chromium-behavior plugin to do this only for Chrome. I did find the same message in Android logs though, so it seems generically useful.
,
Dec 15
Closing here since this is now better tracked in buganizer. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tandrii@chromium.org
, Sep 17Components: -Infra>Git>Admin Infra>Codereview>Gerrit