New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883968 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Rename build id from basebuildmodel

Project Member Reported by lijeffrey@chromium.org, Sep 13

Issue description

build_id is the bid of the buildbucket build, but is currently being used as the build key for BaseBuildModel.py. As build_id will also be added to BaseBuildModel, this will get incredibly confusing.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9c316bc39588a6df0f7076f5b1a029f400f9e64b

commit 9c316bc39588a6df0f7076f5b1a029f400f9e64b
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Sep 13 23:48:50 2018

[Findit] Renaming build_id from BaseBuildModel

No functional change
1. Rename BaseBuildModel.CreateBuildId --> CreateBuildKey
2. Rename BaseBuildModel.GetBuildInfoFromId --> GetBuildInfoFromBuildKey

This is in preparation to introduce the buildbucket_id of the build as
build_id to avoid confusion, as the previous definition of build_id in
this context refers to a 'master/builder/build_number' which is actually
a build key.

Bug:  883968 
Change-Id: Ic7a3fe05796968549c68df1e8b8a8cfbb0ee6859
Reviewed-on: https://chromium-review.googlesource.com/1225771
Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17586}
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/flake_failure/culprit_util.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/compile_failure/compile_try_job.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/compile_failure/revert_and_notify_compile_culprit_pipeline.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/flake_failure/test/culprit_util_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_failure_group.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/dto/create_and_submit_revert_input.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/base_build_model.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/endpoint_api.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/handlers/triage_suspected_cl.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_build.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/flake_failure/test/create_and_submit_revert_pipeline_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_suspected_cl.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/handlers/build_failure.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/waterfall/test/suspected_cl_util_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/handlers/test/build_failure_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_swarming_task.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/handlers/handlers_util.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/test_failure/test/revert_and_notify_test_culprit_pipeline_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/util_scripts/remote_queries/detection_rate_at_step_level.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/test_failure/test_failure_analysis.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/compile_failure/test/revert_and_notify_compile_culprit_pipeline_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/test/findit_api_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/test/base_build_model_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_try_job.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_analysis.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/parameters.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/test/create_revert_cl_pipeline_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/test_failure/test_try_job.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/pipelines/test_failure/revert_and_notify_test_culprit_pipeline.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/handlers/culprit.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/waterfall/suspected_cl_util.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/services/test_failure/test/test_failure_analysis_test.py
[modify] https://crrev.com/9c316bc39588a6df0f7076f5b1a029f400f9e64b/appengine/findit/model/wf_step.py

Status: Fixed (was: Assigned)

Sign in to add a comment