New issue
Advanced search Search tips

Issue 883967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Disable swipe to reveal home launcher on M70.

Project Member Reported by sammiequon@chromium.org, Sep 13

Issue description

Its enabled by default but it should be disabled by default on M70 and enabled on M71.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1177d46414323c268a13ccb68d0b810c2b2a8ae4

commit 1177d46414323c268a13ccb68d0b810c2b2a8ae4
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Sep 17 16:41:43 2018

applist: Home launcher gestures should be disabled by default.

We will merge this to M70 and then revert the M71 change.

Test: none
Bug:  883967 
Change-Id: Ia9de556ca7c2304add2076b347b3cf206d455c84
Reviewed-on: https://chromium-review.googlesource.com/1226274
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591704}
[modify] https://crrev.com/1177d46414323c268a13ccb68d0b810c2b2a8ae4/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/1177d46414323c268a13ccb68d0b810c2b2a8ae4/ash/public/cpp/app_list/app_list_features.cc

Labels: Merge-Request-70
Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/961d3428c5095c1891132b29045f84041457d04e

commit 961d3428c5095c1891132b29045f84041457d04e
Author: Sammie Quon <sammiequon@chromium.org>
Date: Mon Sep 17 18:40:29 2018

Revert "applist: Home launcher gestures should be disabled by default."

This reverts commit 1177d46414323c268a13ccb68d0b810c2b2a8ae4.

Revert because we just want to disabled for M70.

Original change's description:
> applist: Home launcher gestures should be disabled by default.
> 
> We will merge this to M70 and then revert the M71 change.
> 
> Test: none
> Bug:  883967 
> Change-Id: Ia9de556ca7c2304add2076b347b3cf206d455c84
> Reviewed-on: https://chromium-review.googlesource.com/1226274
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591704}

TBR=xiyuan@chromium.org,sammiequon@chromium.org

Change-Id: I44502ddc6ace1f744365a2c607d79f3c0c454e8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  883967 
Reviewed-on: https://chromium-review.googlesource.com/1228236
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591749}
[modify] https://crrev.com/961d3428c5095c1891132b29045f84041457d04e/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/961d3428c5095c1891132b29045f84041457d04e/ash/public/cpp/app_list/app_list_features.cc

Status: Started (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 21

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3366054859be7bb4a8f36b8916ac5294665e72f

commit b3366054859be7bb4a8f36b8916ac5294665e72f
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Sep 21 23:32:43 2018

applist: Home launcher gestures should be disabled by default.

We will merge this to M70 and then revert the M71 change.

Test: none
Bug:  883967 
Change-Id: Ia9de556ca7c2304add2076b347b3cf206d455c84
Reviewed-on: https://chromium-review.googlesource.com/1226274
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591704}(cherry picked from commit 1177d46414323c268a13ccb68d0b810c2b2a8ae4)
Reviewed-on: https://chromium-review.googlesource.com/1239626
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#577}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b3366054859be7bb4a8f36b8916ac5294665e72f/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/b3366054859be7bb4a8f36b8916ac5294665e72f/ash/public/cpp/app_list/app_list_features.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/b3366054859be7bb4a8f36b8916ac5294665e72f

Commit: b3366054859be7bb4a8f36b8916ac5294665e72f
Author: sammiequon@google.com
Commiter: newcomer@chromium.org
Date: 2018-09-21 23:32:43 +0000 UTC

applist: Home launcher gestures should be disabled by default.

We will merge this to M70 and then revert the M71 change.

Test: none
Bug:  883967 
Change-Id: Ia9de556ca7c2304add2076b347b3cf206d455c84
Reviewed-on: https://chromium-review.googlesource.com/1226274
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591704}(cherry picked from commit 1177d46414323c268a13ccb68d0b810c2b2a8ae4)
Reviewed-on: https://chromium-review.googlesource.com/1239626
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#577}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Started)

Sign in to add a comment