New issue
Advanced search Search tips

Issue 883956 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Fix a typo in setting interval for swap_chain_->Present1(UINT interval,..)

Project Member Reported by magchen@chromium.org, Sep 13

Issue description

Chrome Version: (M71)
OS: (Win10)


The original code:
UINT interval = first_swap_ || !vsync_enabled_ || allow_tearing_ ? 0 : 1;
swap_chain_->Present1(interval, flags, &params)

The new code:
UINT interval = first_swap_ || vsync_enabled_ || allow_tearing_ ? 0 : 1;


IDXGISwapChain1::Present1(interval, flags, &params)
Definition for interval
 0 - The presentation occurs immediately, there is no synchronization.
 1 through 4 - Synchronize presentation after the nth vertical blank.

When vsync_enabled_ == 0, the presentation should occurs immediately,
When vsync_enabled_ == 1, the presentation should occurs after next vsync.

 
Description: Show this description
Description: Show this description
Summary: Fix a typo in setting interval for swap_chain_->Present1(UINT interval,..) (was: Fix a typo in the logic for setting the interval in swap_chain_->Present1(interval,..))
Cc: zmo@chromium.org sunn...@chromium.org
Cc: -sunn...@chromium.org -zmo@chromium.org
Status: Closed (was: Assigned)
Turn out this is not a typo.

Sign in to add a comment