New issue
Advanced search Search tips

Issue 883949 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Sep 28
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] Implement graphics layer output using cc::Layer state

Project Member Reported by pdr@chromium.org, Sep 13 
GraphicsLayerTreeAsJSON (called from GraphicsLayerTreeAsTextForTesting in graphics_layer_tree_as_text.h) currently prints out GraphicsLayer state but should print out the cc::Layer state with BlinkGenPropertyTrees enabled (--enable-blink-gen-property-trees). This may affect layout tests which use the graphics layer dumps.

Bonus points are available for anyone who renames graphics_layer_tree_as_text to graphics_layer_list_as_text.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa8368091a2b3661dfacc5a44052c6e8a7269db

commit aaa8368091a2b3661dfacc5a44052c6e8a7269db
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Sep 14 23:05:06 2018

[BGPT] Stop caching position_ on GraphicsLayer and instead use the value on cc::Layer directly.

This improves BGPT testing to take into account layer position updates due to PAC, and also
reduces GraphicsLayer size a little bit. It exposes gfx::PointF directly to some code in core,
but that is ok because we already decided that gfx types are ok in core and this is just for
SPv1 compositing.

Bug:  883949 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6c0423aa66e94c24e96331381e6523ba1fb574b6
Reviewed-on: https://chromium-review.googlesource.com/1227301
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591514}
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/platform/geometry/float_point.cc
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/platform/geometry/float_point.h
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/aaa8368091a2b3661dfacc5a44052c6e8a7269db/third_party/blink/renderer/platform/graphics/graphics_layer.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e42a8c7719a57709fbe2f0d2c50c264ccea7653

commit 8e42a8c7719a57709fbe2f0d2c50c264ccea7653
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Sep 20 01:02:15 2018

[BGPT] Stop caching size_ on GraphicsLayer and instead use the value on cc::Layer directly.

This improves BGPT testing, and makes GraphicsLayer a bit smaller.

Bug:  883949 


Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I97a09fd97085e6a157251348dfbadc175fa76a59
Reviewed-on: https://chromium-review.googlesource.com/1227680
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592642}
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/frame/visual_viewport.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/inspector/inspector_layer_tree_agent.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/layout/scrollbars_test.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/page/page_overlay.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/paint/paint_layer_painter.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/core/scroll/scrollable_area_test.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/platform/geometry/float_point.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/platform/geometry/float_point.h
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/platform/geometry/layout_size.h
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/8e42a8c7719a57709fbe2f0d2c50c264ccea7653/third_party/blink/renderer/platform/graphics/graphics_layer.h
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e337262e101e86c301d78ffa4337311f7d2d9110

commit e337262e101e86c301d78ffa4337311f7d2d9110
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Sep 27 20:07:55 2018

[BGPT] Remove a bunch more fields from GraphicsLayer.

This improves BGPT testing, and slims GraphicsLayer a bit.

Bug:  883949 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I77d5108dd2309de33a52ca90e3592c2d22ea28a0
Reviewed-on: https://chromium-review.googlesource.com/1247037
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594837}
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/platform/geometry/float_point.cc
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/platform/geometry/float_point.h
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/platform/geometry/float_point_3d.cc
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/platform/geometry/float_point_3d.h
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/e337262e101e86c301d78ffa4337311f7d2d9110/third_party/blink/renderer/platform/graphics/graphics_layer.h

Comment 4 by chrishtr@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment