New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883946 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Undefined behavior for source updates in page_timing_metrics_sender

Project Member Reported by johnidel@chromium.org, Sep 13

Issue description

Currently resources that are modified between timing updates in page_timing_metrics_sender are held as a set of pointers to PageResourceDataUse objects. However, these are stored in a small map, which invalidates iterators/pointers on insertion, causing undefined behavior when using |modified_resources_|. 

See: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935570890389859808/+/steps/browser_tests__with_patch_/0/logs/AutoplayMetricsBrowserTest.RecordAutoplayAttemptUkm/0 for one such example.
 
Status: Fixed (was: Untriaged)
Fixed on: https://chromium-review.googlesource.com/c/chromium/src/+/1224656
(merged before bug created).

Sign in to add a comment