New issue
Advanced search Search tips

Issue 883943 link

Starred by 1 user
Status: Fixed
Owner:
tienmai@chromium.org
Closed: Oct 16
Cc:
grt@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chromium branded credential provider should build differently from Google Chrome brand provider

Project Member Reported by rogerta@chromium.org, Sep 13 
The credential provider is built for both chromium and Google Chrome branded builds.  The former is useful so that unit tests will run on the chromium waterfall.  However, this has other side effects:

- both chromium branded and Google Chrome branded builds use the same CLSIDs for registered COM objects.  They should use different values.

- the chromium branded builds touches registry values under SOFTWARE\Google when it should SOFTWARE\Chromium

- the chromium branded builds should not touches registry values under SOFTWARE\Google\Update

Comment 1 by rogerta@chromium.org, Oct 5

Labels: gcpw

Comment 2 by rogerta@chromium.org, Oct 10

Owner: tienmai@chromium.org
Status: Started (was: Assigned)

Comment 3 by rogerta@chromium.org, Oct 15

Components: Enterprise>CredentialProvider

Comment 4 by rogerta@chromium.org, Oct 15

Components: -Enterprise

Comment 5 by rogerta@chromium.org, Oct 15

Labels: -gcpw
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3776054377c89de737297614404d309b7e97b356

commit 3776054377c89de737297614404d309b7e97b356
Author: Tien Mai <tienmai@chromium.org>
Date: Tue Oct 16 18:32:09 2018

Create separate CLSID and registry entries for Chromium / Chrome GCP

- Make sure all registry entries created by GCP is not hardcoded to chrome
- Make sure we can install different versions of the GCP for Chrome/Chromium

Bug:  883943 
Change-Id: I72aa14545ad7b0ab4320b14baf210b3b80979ffe
Reviewed-on: https://chromium-review.googlesource.com/c/1278503
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Tien Mai <tienmai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600056}
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/BUILD.gn
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/dllmain.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/gaia_credential.h
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/gaia_credential_base.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/gaia_credential_provider.rgs
[rename] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/gaia_credential_provider_idl.templ
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/gaia_credential_provider_unittests.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/reauth_credential.h
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/reg_utils.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/reg_utils.h
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/gaiacp/scoped_user_profile.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/setup/setup_lib.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/setup/setup_lib.h
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/chrome/credential_provider/test/gcp_setup_unittests.cc
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider.tlb
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.c
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_i.h
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x64/gaia_credential_provider_p.c
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider.tlb
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.c
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_i.h
[modify] https://crrev.com/3776054377c89de737297614404d309b7e97b356/third_party/win_build_output/midl/chrome/credential_provider/gaiacp/x86/gaia_credential_provider_p.c

Comment 7 by tienmai@chromium.org, Oct 16

Status: Fixed (was: Started)
►

Sign in to add a comment