New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883938 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove RequestQueueInMemoryStore

Project Member Reported by harringtond@chromium.org, Sep 13

Issue description

Instead use RequestQueueStoreSQL in tests. This will make tests more realistic, and remove some code. We should collapse RequestQueueStoreSQL into RequestQueueStore.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02981447973468066f78d4da415f9bdd7e70bad5

commit 02981447973468066f78d4da415f9bdd7e70bad5
Author: Dan Harrington <harringtond@chromium.org>
Date: Wed Sep 19 14:15:10 2018

Remove RequestQueueInMemoryStore

RequestQueueStore and RequestQueueStoreSQL were combined.

I went ahead and added a test fixture for request queue tasks. This ensures
we actually delete the database in TearDown.

Bug:  883938 
Change-Id: Ia56698061685440402d82b5a6836c827f30b546a
Reviewed-on: https://chromium-review.googlesource.com/1227134
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592386}
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/chrome/browser/offline_pages/android/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/chrome/browser/offline_pages/android/request_coordinator_factory.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/chrome/browser/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/chrome/browser/offline_pages/test_request_coordinator_builder.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/BUILD.gn
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/add_request_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/change_requests_state_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/cleanup_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/get_requests_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/initialize_store_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/mark_attempt_aborted_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/mark_attempt_completed_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/mark_attempt_started_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/pick_request_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/reconcile_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/remove_requests_task_unittest.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_coordinator_stub_taco.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_coordinator_unittest.cc
[delete] https://crrev.com/8f6326484a8c1ad74f61585eb0bfc7b1126ce2fa/components/offline_pages/core/background/request_queue_in_memory_store.cc
[delete] https://crrev.com/8f6326484a8c1ad74f61585eb0bfc7b1126ce2fa/components/offline_pages/core/background/request_queue_in_memory_store.h
[rename] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_queue_store.cc
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_queue_store.h
[delete] https://crrev.com/8f6326484a8c1ad74f61585eb0bfc7b1126ce2fa/components/offline_pages/core/background/request_queue_store_sql.h
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_queue_store_unittest.cc
[add] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_queue_task_test_base.cc
[add] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_queue_task_test_base.h
[modify] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/request_queue_unittest.cc
[add] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/test_request_queue_store.cc
[add] https://crrev.com/02981447973468066f78d4da415f9bdd7e70bad5/components/offline_pages/core/background/test_request_queue_store.h

Status: Fixed (was: Assigned)

Sign in to add a comment