Credential provider should delete older version when run |
|||||||||||
Issue descriptionWhen the GCPW installer runs it looks for older installs of GCPW and removes them. However, the removal may fail for various reasons (a DLL or exe is in use, a virus scanner is examining the files, an explorer window is open on the directory, etc.) Right now these older versions will simply remain on the disk until a new version is installed and again tried to delete older versions. To solve this, the credential provider should attempt to delete older versions whenever it runs. There are two possible solutions: - move the function DeleteOlderVersions() in credential_provider/setup/setup_lib.cc to a place where the credential provider can call it. Right now this function exists only in gcp_setup.exe - have the credential provider invoke gcp_setup.exe with a command line arg like --delete-old-versions
,
Oct 5
,
Oct 15
,
Oct 15
,
Oct 15
,
Oct 16
,
Dec 10
,
Dec 12
,
Dec 14
,
Dec 14
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7 commit 6e9bc4938b15c2dc22c7b974178bbecae8b03cc7 Author: Yann Dago <ydago@chromium.org> Date: Mon Dec 17 16:35:25 2018 Credential provider should delete older version when run Cleanup older GCP versions in the default installation folder when the GCP Provider is instantiated Bug: 883935 Change-Id: I420afa9c467b05dba75afa8162b902d9336bb63e Reviewed-on: https://chromium-review.googlesource.com/c/1377381 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#617137} [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/gaiacp/gaia_credential_provider.cc [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/gaiacp/gaia_credential_provider.h [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/gaiacp/gcp_utils.cc [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/gaiacp/gcp_utils.h [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/setup/setup_lib.cc [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/setup/setup_lib.h [modify] https://crrev.com/6e9bc4938b15c2dc22c7b974178bbecae8b03cc7/chrome/credential_provider/test/gcp_setup_unittests.cc
,
Dec 17
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by rogerta@chromium.org
, Sep 13