New issue
Advanced search Search tips

Issue 883922 link

Starred by 1 user
Status: Fixed
Owner:
yigu@chromium.org
Closed: Sep 15
Cc:
majidvp@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-09-15
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Rename Animation Worklet classes

Project Member Reported by yigu@chromium.org, Sep 13 
Now that we are able to tick worklet animations via the main thread, it's time to rename some of the interfaces so that they don't imply "compositor" only. In addition, current usage of 'animator' and 'mutator' on the main thread is inaccurate. They should be addressed as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b61d48d62c814865733eeb3b0a360e83ccf5ef57

commit b61d48d62c814865733eeb3b0a360e83ccf5ef57
Author: Yi Gu <yigu@chromium.org>
Date: Sat Sep 15 04:09:12 2018

Update some 'compositor' prefix in mutator related APIs to 'worklet'

There are some APIs like CompositorMutatorImpl, CompositorAnimator that
are out of date due to the recent change which introduced mutating
animations via the main thread.

In addition, using |Animator| was an unfortunate mistake since we have
an animator concept elsewhere (an in the spec) that is different.

Proposed changes:
CompositorMutator -> AnimationWorkletMutatorDispatcher
WorkletMutatorImpl -> AnimationWorkletMutatorDispatcherImpl
CompositorAnimator -> AnimationWorkletMutator
CompositorMutatorInput[Output]State -> AnimtionWorkletDispatcherInput[Output]

Bug:  839341 ,  883922 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic97a125d021ec2a62174d897c9bf67b522130881
Reviewed-on: https://chromium-review.googlesource.com/1224494
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591573}
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/cc/animation/animation_host.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/cc/animation/animation_host_unittest.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/cc/test/mock_layer_tree_mutator.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/cc/trees/layer_tree_mutator.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/animation/worklet_animation_base.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/animation/worklet_animation_controller.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/animation/worklet_animation_controller.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/frame/web_frame_widget_base.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/frame/web_frame_widget_impl.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/frame/web_view_frame_widget.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/core/frame/web_view_frame_widget.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animation_worklet.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client_impl.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client_impl.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animator.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/animator.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/modules/animationworklet/worklet_animation.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/BUILD.gn
[add] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/animation_worklet_mutator.h
[add] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher.h
[add] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.cc
[add] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.h
[add] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl_test.cc
[add] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/animation_worklet_mutators_state.h
[delete] https://crrev.com/02eead20bf893a9734e906559e52429879bf48c8/third_party/blink/renderer/platform/graphics/compositor_animator.h
[delete] https://crrev.com/02eead20bf893a9734e906559e52429879bf48c8/third_party/blink/renderer/platform/graphics/compositor_animators_state.h
[delete] https://crrev.com/02eead20bf893a9734e906559e52429879bf48c8/third_party/blink/renderer/platform/graphics/compositor_mutator.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/compositor_mutator_client.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/compositor_mutator_client.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/main_thread_mutator_client.cc
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/main_thread_mutator_client.h
[modify] https://crrev.com/b61d48d62c814865733eeb3b0a360e83ccf5ef57/third_party/blink/renderer/platform/graphics/mutator_client.h
[delete] https://crrev.com/02eead20bf893a9734e906559e52429879bf48c8/third_party/blink/renderer/platform/graphics/worklet_mutator_impl.cc
[delete] https://crrev.com/02eead20bf893a9734e906559e52429879bf48c8/third_party/blink/renderer/platform/graphics/worklet_mutator_impl.h
[delete] https://crrev.com/02eead20bf893a9734e906559e52429879bf48c8/third_party/blink/renderer/platform/graphics/worklet_mutator_impl_test.cc

Comment 2 by yigu@chromium.org, Sep 15

NextAction: 2018-09-15
Status: Fixed (was: Assigned)

Comment 3 by monor...@bugs.chromium.org, Sep 15 

The NextAction date has arrived: 2018-09-15
►

Sign in to add a comment