New issue
Advanced search Search tips

Issue 883911 link

Starred by 2 users
Status: Fixed
Owner:
zentaro@chromium.org
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add crypto support to oobe_config

Project Member Reported by zentaro@chromium.org, Sep 13 
Support encrypting and decrypting data with TPM sealed key.

Used to store rollback data.

Comment 1 by weifangsun@chromium.org, Sep 21

Components: UI>Shell>OOBE

Comment 2 by zalcorn@chromium.org, Nov 13

Components: -UI>Shell>OOBE Internals>Installer
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f277421e3544dfe517daa71856c8e789e8a6c8e8

commit f277421e3544dfe517daa71856c8e789e8a6c8e8
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:57 2018

chromeos-base/libtpmcrypto: Add new package

- Supports AES256-GCM encryption to a serialized proto
- Supports sealing/unsealing key with TPM

BUG= chromium:883911 
TEST=emerges and unittests

Change-Id: I12db321d480cd5ca74ec3688397c7df45d8bad54
Reviewed-on: https://chromium-review.googlesource.com/1307853
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/f277421e3544dfe517daa71856c8e789e8a6c8e8/chromeos-base/libtpmcrypto/libtpmcrypto-9999.ebuild
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0c8669cf917d7d0641ef5ac3dcbff1fff2d0b6b0

commit 0c8669cf917d7d0641ef5ac3dcbff1fff2d0b6b0
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:57 2018

libtpmcrypto: Add and consume use flags for tpm 1 and 2

- Add dependency on trunks for tpm2

BUG= chromium:883911 
TEST=emerges and unittests

Change-Id: Iab14e2a75f7fd6fb5c3bc015b8c6580f4ef55235
Reviewed-on: https://chromium-review.googlesource.com/1342726
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0c8669cf917d7d0641ef5ac3dcbff1fff2d0b6b0/chromeos-base/libtpmcrypto/libtpmcrypto-9999.ebuild
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2ccfe267f479424ed5a573d697fe3125d4be7ab7

commit 2ccfe267f479424ed5a573d697fe3125d4be7ab7
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:58 2018

libtpmcrypto: Add trousers dependency for tpm 1

BUG= chromium:883911 
TEST=emerges and unittests

Change-Id: I2a76735b457f3965dbec6550cc39baf31d0206bc
Reviewed-on: https://chromium-review.googlesource.com/1347194
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/2ccfe267f479424ed5a573d697fe3125d4be7ab7/chromeos-base/libtpmcrypto/libtpmcrypto-9999.ebuild
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/43558d9929979a8ea0bd183fc163a28d9bbba342

commit 43558d9929979a8ea0bd183fc163a28d9bbba342
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:56 2018

libtpmcrypto: Adds TPM2 implementation

- Implements Tpm interface for TPM2
- Includes SealKey and UnsealKey functionality

CQ-DEPEND=CL:1342726
BUG= chromium:883911 
TEST=emerges and manual test

Change-Id: I6f8566b971e57aff8f2e22a3e1b571daf8b2fba1
Reviewed-on: https://chromium-review.googlesource.com/1308516
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/43558d9929979a8ea0bd183fc163a28d9bbba342/libtpmcrypto/tpm2_impl.h
[modify] https://crrev.com/43558d9929979a8ea0bd183fc163a28d9bbba342/libtpmcrypto/BUILD.gn
[add] https://crrev.com/43558d9929979a8ea0bd183fc163a28d9bbba342/libtpmcrypto/tpm2_impl.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/04eb2b0e918f2772f508c64d26c1523fd4ecf410

commit 04eb2b0e918f2772f508c64d26c1523fd4ecf410
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:56 2018

libtpmcrypto: Adds TPM1 implementation

- Implements Tpm interface for TPM1
- Includes GetRandom, SealKey and UnsealKey functionality

CQ-DEPEND=CL:1347194

BUG= chromium:883911 
TEST=emerges and manual test

Change-Id: I7521b6751a8956e5f11b4a02c451f30342dd20a3
Reviewed-on: https://chromium-review.googlesource.com/1308517
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/04eb2b0e918f2772f508c64d26c1523fd4ecf410/libtpmcrypto/tpm1_impl.cc
[modify] https://crrev.com/04eb2b0e918f2772f508c64d26c1523fd4ecf410/libtpmcrypto/BUILD.gn
[add] https://crrev.com/04eb2b0e918f2772f508c64d26c1523fd4ecf410/libtpmcrypto/tpm1_impl.h
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8034a39d21850c2fec1dc97e0165270248dfef94

commit 8034a39d21850c2fec1dc97e0165270248dfef94
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:55 2018

libtpmcrypto: Fix header guards

BUG= chromium:883911 
TEST=emerges

Change-Id: I43e2e7d96495f610c4db8b9068adccf753f1116f
Reviewed-on: https://chromium-review.googlesource.com/1347133
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/8034a39d21850c2fec1dc97e0165270248dfef94/libtpmcrypto/tpm_proto_utils.h
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bf6848510f2ea7872f883c570a367716a679eb84

commit bf6848510f2ea7872f883c570a367716a679eb84
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Nov 22 06:48:55 2018

libtpmcrypto: Add Tpm interface

- Implementation already reviewed on CL:1308516 and CL:1308517

BUG= chromium:883911 
TEST=emerges and unittests

Change-Id: Ifccfb1de1ae2350e6a3cdb9feb7d382327ede676
Reviewed-on: https://chromium-review.googlesource.com/1347134
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/bf6848510f2ea7872f883c570a367716a679eb84/libtpmcrypto/tpm.h
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/da5bbdac801befa0ca9c963c13d0750ce191601f

commit da5bbdac801befa0ca9c963c13d0750ce191601f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Nov 23 03:07:34 2018

oobe_config: Add support for encrypting during save and restore

BUG= chromium:883911 
TEST=unittests

Change-Id: Ic2a1ad64c403b8c1e0ece19e62c2fcf19bcba8a3
Reviewed-on: https://chromium-review.googlesource.com/1332550
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/da5bbdac801befa0ca9c963c13d0750ce191601f/oobe_config/oobe_config_save_main.cc
[modify] https://crrev.com/da5bbdac801befa0ca9c963c13d0750ce191601f/oobe_config/oobe_config_restore_main.cc
[modify] https://crrev.com/da5bbdac801befa0ca9c963c13d0750ce191601f/oobe_config/load_oobe_config_rollback.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4057db47e6f397c88f0c1d636311fc4a0abad27f

commit 4057db47e6f397c88f0c1d636311fc4a0abad27f
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Nov 23 03:07:32 2018

oobe_config: Add a stub TpmCrypto to unblock dependencies

- Adds a stub implementation that throws NOTREACHED
- When real implementation lands, this can be deleted.

BUG= chromium:883911 
TEST=emerges and unittests

Change-Id: Id6bc4c834f801f0c4ca726fe728656b8f94893f3
Reviewed-on: https://chromium-review.googlesource.com/1347142
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[add] https://crrev.com/4057db47e6f397c88f0c1d636311fc4a0abad27f/oobe_config/tpm_crypto_impl.h
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ebe7d4dcba6dc3a49a61ab217139fd39942478c0

commit ebe7d4dcba6dc3a49a61ab217139fd39942478c0
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Wed Nov 28 20:47:58 2018

libtpmcrypto: Add implementation of AEC256-GCM

- Lightweight support for encrypting and decrypting
  blobs with a TPM backed key
- Implements AES256-GCM
- Tests with a fake TPM implementation

BUG= chromium:883911 
TEST=emerges

Change-Id: Ic4862738a93e58416d025d959eba77d870b9e3cd
Reviewed-on: https://chromium-review.googlesource.com/1308515
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

[add] https://crrev.com/ebe7d4dcba6dc3a49a61ab217139fd39942478c0/libtpmcrypto/tpm_crypto.h
[add] https://crrev.com/ebe7d4dcba6dc3a49a61ab217139fd39942478c0/libtpmcrypto/tpm_crypto_impl.h
[add] https://crrev.com/ebe7d4dcba6dc3a49a61ab217139fd39942478c0/libtpmcrypto/tpm_crypto_impl.cc
[modify] https://crrev.com/ebe7d4dcba6dc3a49a61ab217139fd39942478c0/libtpmcrypto/BUILD.gn
[add] https://crrev.com/ebe7d4dcba6dc3a49a61ab217139fd39942478c0/libtpmcrypto/tpm_crypto_impl_test.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b9694cf975ff0d21a63b1716e4d4f7b5ee789c10

commit b9694cf975ff0d21a63b1716e4d4f7b5ee789c10
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Mon Dec 03 20:43:26 2018

cros image test: Update tss group baseline for oobe_config

- Adds the oobe_config_save and oobe_config_restore users to tss
  group
- These are used to encrypt rollback data across a powerwash
- See CL/1254945 for review of adding these users

BUG= chromium:883911 
TEST=none

Change-Id: I5d65cb97dfbcf3f30a9e313b5d9e806f9390b2a3
Reviewed-on: https://chromium-review.googlesource.com/1357324
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b9694cf975ff0d21a63b1716e4d4f7b5ee789c10/cros/test/usergroup_baseline.py
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/fe9b97f19044a14ce0e933465d0d24cdba2a0a08

commit fe9b97f19044a14ce0e933465d0d24cdba2a0a08
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Mon Dec 03 20:43:27 2018

Add oobe_config users to tss group

- Adds oobe_config_save and oobe_config_restore users to tss
  group, so that they can talk to the TPM via tcsd

CQ-DEPEND=CL:1357324

BUG= chromium:883911 
TEST=emerges, has permission

Change-Id: I8c80506db27a1e65286173d77dfae3c13d3d37d5
Reviewed-on: https://chromium-review.googlesource.com/1254945
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Andrey Pronin <apronin@chromium.org>

[modify] https://crrev.com/fe9b97f19044a14ce0e933465d0d24cdba2a0a08/profiles/base/accounts/group/tss

Comment 15 by zentaro@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment