New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883907 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 837855



Sign in to add a comment

Display test names with masks

Project Member Reported by liaoyuke@chromium.org, Sep 13

Issue description

for test names with parameters, we'd want to display the test with variable parts being replaced with '*' to avoid confusions.

For example, 'suite.test/2' -> 'suite.test/*'
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7b1784453af2dc2befc9f668516855efb2712ea2

commit 7b1784453af2dc2befc9f668516855efb2712ea2
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Sep 13 20:53:20 2018

[Findit] Add test_label_name for Flake Model

This CL introduces test_label_name for the Flake data model,
test_label_name is the same as the normalized test name except that the
variable parts are replaced with '*' instead of being removed.

This CL also changes the issue tracker service to use the
test_label_name to file bugs. Another implication of this change is
that since the bug doesn't refer to any specific test instance anymore,
Flake Analyzer's bug description and bug comments are changed to
include the original test name, or otherwise, users would have no idea
which specific test instance Flake Analyzer is referring to.

Bug:  883907 
Change-Id: I48b5e0ef118b0adb209cc2afa40a21c24a42cdd6
Reviewed-on: https://chromium-review.googlesource.com/1224955
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17574}
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/model/flake/detection/test/flake_occurrence_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_detection/flake_report_util.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_detection/test/detect_cq_false_rejection_flakes_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/test/issue_tracking_service_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/libs/test/test_name_util_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/issue_tracking_service.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/model/flake/test/flake_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/libs/test_name_util.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_failure/test/flake_report_util_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_detection/test/flake_report_util_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_detection/test/update_flake_counts_service_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_failure/flake_report_util.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/model/flake/flake.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/handlers/flake/detection/test/show_flake_test.py
[modify] https://crrev.com/7b1784453af2dc2befc9f668516855efb2712ea2/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py

Status: Fixed (was: Started)

Sign in to add a comment