MultiDevice settings: "Forget device" prompt feels unpolished |
|||||
Issue descriptionChrome Version: head Screenshot attached. The body text should at least be aligned with the title. Additionally, does the body text feel a bit too terse to anyone else? Can user be expected to understand what exactly "Remove your phone" means?
,
Sep 13
The mock is here: https://docs.google.com/presentation/d/1hloC0CmSxtuwHbVLbKSaq1HWpxyYt4EDTTxMuPu0wHc/edit#slide=id.g308d9b89f8_0_309 It looks like the body should be left-aligned with the title. Besides that, the only other differences are the button style and the "X" in the upper-right, but those are the same button/X styles used by all other dialogs in settings. I think we should keep those styles for uniformity with the rest of the page.
,
Sep 13
Shiba reached out and said that she agrees with my assessment in comment #2.
,
Sep 14
,
Sep 20
,
Oct 2
This looks like something I can pretty easily do while home sick, so I'm just going to take it. Messing around in the dev tools, it looks like I can just remove a class to fix this.
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba1269835a6aa4b496d6979bc27012ac4609c95b commit ba1269835a6aa4b496d6979bc27012ac4609c95b Author: Jeremy Klein <jlklein@google.com> Date: Wed Oct 03 01:47:04 2018 Fix padding in "forget device" dialog. Align the body contents with the dialog title by just removing an unneeded css class. Screenshot: http://screen/ajbr1Bsq4kB Bug: 883906 Change-Id: I54baadb308c54b440f1fbdc99d8bc5572e135cba Reviewed-on: https://chromium-review.googlesource.com/c/1258506 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596088} [modify] https://crrev.com/ba1269835a6aa4b496d6979bc27012ac4609c95b/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html
,
Oct 3
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jhawkins@chromium.org
, Sep 13