This is an umbrella feature bug. We will put some Omnibox keyword mode experiments under it, including: - keyword button UI visibility experiments - keyword mode suggestion type inclusion changes - keyword suggestions display changes
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ac8bf43fcb15c1ab51d57e8668b5167732279b1 commit 4ac8bf43fcb15c1ab51d57e8668b5167732279b1 Author: Kevin Bailey <krb@chromium.org> Date: Thu Sep 13 19:17:42 2018 [omnibox] Add experiment flag for keyword mode features Just adding a flag to put some experiments related to keyword mode under. Bug: 883901 Change-Id: If101d7c7dfeb8910b7e7a0a81eaff075a26fe9af Reviewed-on: https://chromium-review.googlesource.com/1224602 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#591106} [modify] https://crrev.com/4ac8bf43fcb15c1ab51d57e8668b5167732279b1/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/4ac8bf43fcb15c1ab51d57e8668b5167732279b1/components/omnibox/browser/omnibox_field_trial.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/085c55b54f7e3bf738b8df93a69c3be831310df2 commit 085c55b54f7e3bf738b8df93a69c3be831310df2 Author: Kevin Bailey <krb@chromium.org> Date: Wed Sep 26 21:54:17 2018 [omnibox] Keyword mode experiment: Try more visible button This CL describes an experiment to see if a dark blue keyword mode button will make it more visible and attention-getting. Bug: 883901 Change-Id: Ibef0b56b1a36f6debae0a446123632e173448c48 Reviewed-on: https://chromium-review.googlesource.com/1234035 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#594488} [modify] https://crrev.com/085c55b54f7e3bf738b8df93a69c3be831310df2/chrome/browser/ui/omnibox/omnibox_theme.cc [modify] https://crrev.com/085c55b54f7e3bf738b8df93a69c3be831310df2/chrome/browser/ui/views/location_bar/keyword_hint_view.cc [modify] https://crrev.com/085c55b54f7e3bf738b8df93a69c3be831310df2/chrome/browser/ui/views/location_bar/keyword_hint_view.h [modify] https://crrev.com/085c55b54f7e3bf738b8df93a69c3be831310df2/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/085c55b54f7e3bf738b8df93a69c3be831310df2/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/085c55b54f7e3bf738b8df93a69c3be831310df2/components/omnibox/browser/omnibox_field_trial.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/489b17d054896796ede1669b0544d18b9b4900b5 commit 489b17d054896796ede1669b0544d18b9b4900b5 Author: Kevin Bailey <krb@chromium.org> Date: Tue Jan 22 14:44:11 2019 [omnibox] Experiment to reduce non-keyword suggestions in keyword mode Under flag, if the user explicitly enters keyword mode, don't show non-keyword suggestions. Bug: 883901, 837395 Change-Id: Iac221e194ce20205e1a40a4ff4a74ea8fec024f6 Reviewed-on: https://chromium-review.googlesource.com/c/1258089 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#624775} [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/autocomplete_classifier.cc [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/autocomplete_input.cc [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/autocomplete_input.h [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/omnibox_field_trial.h [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/search_provider.cc [modify] https://crrev.com/489b17d054896796ede1669b0544d18b9b4900b5/components/omnibox/browser/search_provider.h
Comment 1 by bugdroid1@chromium.org
, Sep 13