New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883900 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

devices wrongly getting AUE notices

Project Member Reported by vapier@chromium.org, Sep 13

Issue description

Chrome Version       : 71.0.3544.0
OS Version: 11059.0.0
URLs (if applicable): chrome://settings/help

What steps will reproduce the problem?
1. go to chrome://settings/help after waking up the device
2. see the AUE notice (see attached screenshot)

i've seen this on my pixelbook (eve) as well as astronaut

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 11059.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3544.0 Safari/537.36
 
Screenshot 2018-09-13 at 14.10.15.png
91.7 KB View Download
Cc: abod...@chromium.org mkarkada@chromium.org dhadd...@chromium.org sdantul...@chromium.org
What is the value if you run the following in the terminal?
$update_engine_client --eol_status

I think only eol status=eol will trigger eol notice.
these devices don't have dev-mode enabled, so i can't run UE

i just filed feedback (had meant to earlier but forgot) and referenced this bug.  hopefully the logs in there are still new enough.  if i see it again, i'll file more feedback.
Labels: Hotlist-ConOps-CrOS
Status: Untriaged (was: Unconfirmed)
Seeing one user report about this as well on a Hana device (hana-signed-mp-v4keys): https://listnr.corp.google.com/report/85673713776

Listnr report includes screenshot and logs.

In the logs, I see this message:

[ERROR:object_proxy.cc(617)] Failed to call method: org.chromium.UpdateEngineInterface.GetEolStatus: object_path= /org/chromium/UpdateEngine: org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
[ERROR:update_engine_client.cc(418)] Failed to request getting eol status

Are we triggering EOL notice if we don't have EOL status?
Cc: r...@chromium.org steve...@chromium.org
Labels: -Pri-3 Pri-1
Bumping to Pri-1 - we shouldn't be telling users their devices are obsolete unless it's true.
Cc: abodenha@chromium.org
Whom would be the right owner for this?

We should try to get a fix in soon, if this happens beyond 71 we cannot block the release on it, but this is going to cause a lot of panic for end users if it happens. 
User feedback about same issue from Kevin (same user, multiple reports):
M69 - http://listnr/product/208/report/85685298554
M68 - http://listnr/product/208/report/85669893293
 Issue 889367  has been merged into this issue.
Dupped  https://crbug.com/889367  to this bug; includes more details about this issue on Kevin.

Seems like in each case reported, the UI for the Settings Page isn't fully loading or is off and is mistakenly showing the AUE message.
Looks like we have 9 reports about this over the last 90 days, with nearly all from devices running M67, M68, or M69.

Hana (included above): http://listnr/product/208/report/85673713776
Kevin (included above): https://listnr.corp.google.com/report/85669893293
Kevin (included above): https://listnr.corp.google.com/report/85685298554

SORAKA (Googler): https://listnr.corp.google.com/report/85581761446
Caroline: https://listnr.corp.google.com/report/85569735168
Daisy: https://listnr.corp.google.com/report/85550192076
Cyan: https://listnr.corp.google.com/report/85535864829

Same issue for me on Samsung Chromebook Plus at update to September 13 build.  Since then the device has also been overheating and experiencing various crashes and WebGL crashes. 

Here are the screen shots in case you need them and a pdf with the os details.  I had another ticket open for the issue as I was unable to find this one initially.  
 Issue 889367 . 


Screenshot 2018-09-18 at 8.46.33 PM.png
272 KB View Download
Screenshot 2018-09-18 at 8.47.25 PM.png
335 KB View Download
Screenshot 2018-09-18 at 8.47.59 PM.png
425 KB View Download
Problems from Updates to 69.pdf
450 KB Download
The 1st screenshot at comment #12 indicates that some error has occurred in the page causing the UI to be fairly broken. Those 3 buttons are never supposed to be shown at the same time.

@cuzin.it1102@gmail.com (or anyone who can repro): Can you open the DevTools and paste a screenshot of any errors you see there?
Labels: ReleaseBlock-Stable
Tempted to mark this a beta blocker. We need to be EXTREMELY careful about this messaging. Showing a message like this to users of recent devices on stable channel would be a disaster.
Components: -UI>Settings UI>Shell>Notifications Internals>Installer
Labels: -ReleaseBlock-Stable ReleaseBlock-Beta M-71
Owner: xiaoyinh@chromium.org
Status: Assigned (was: Untriaged)
Settings isn't the right component for this.

xiaoyinh@ can you lead the investigation here?

There are two things that need to happen that I see:
1: EOL UI should ONLY trigger if we have a definite POSITIVE EOL signal from Omaha.
2: We need to figure out why the EOL check is misbehaving.
The Settings UI related code that displays the warning is at [1] and [2]. If I manually populate these with false/true locally I get the expected results.

When the issue happens, there is obviously something wrong going on the page (revealed by the 3 buttons showing at the same time). My suspicion is that something unexpected is returned from the C++ side to the UI, triggering the errors. This is also supported by the error shown at comment #4.

Without a consistent repro it is hard to confidently say whether the root cause is frontend or backend.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.html?l=148-154
[2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.js?l=179-181
The property that controls all three buttons' visibility does not have a default value, and looks like they all depends on the information we got from C++ side.

Maybe the C++->JS callback was broken somehow and we didn't get any information from c++ side. I tried to commented out this section[1] and was able to get a similar result.

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.js?l=169-181&rcl=ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3 

Comment 19 Deleted

abodenha@chromium.org I am on stable channel.  This is happening on stable channel and displaying this to users on stable channels. 
Adding screenshots for before vs after(with cl in comment 18), besides commenting out https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/about_page/about_page.js?l=169-181&rcl=ce3f8e667dbdd9d350e6527aad5c99024d3ad2c3 


before.png
187 KB View Download
after.png
159 KB View Download
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac531badbf2aa7af4727d4699f909e3c251ff675

commit ac531badbf2aa7af4727d4699f909e3c251ff675
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Sep 27 23:11:42 2018

Set default value for buttons and eol state.

Currently button and eol states are pulled from C++ side.
In some broken state, c++ does not provide any information and about
page end up showing all 3 buttons and eol state at the same time.

Bug:  883900 
Change-Id: I70788e3c3634dd11586c515c89ef499409d155e5
Reviewed-on: https://chromium-review.googlesource.com/1247185
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594910}
[modify] https://crrev.com/ac531badbf2aa7af4727d4699f909e3c251ff675/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/ac531badbf2aa7af4727d4699f909e3c251ff675/chrome/test/data/webui/settings/about_page_tests.js

Fix is landed in comment 22. Does it need to be merged back to M70?
imo we should merge it to M70
Labels: Merge-Request-70
Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 27 by bugdroid1@chromium.org, Sep 28

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b4357a529bd46ab097f6330c8648e8f80f5cfa8

commit 1b4357a529bd46ab097f6330c8648e8f80f5cfa8
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Fri Sep 28 17:49:10 2018

[Merge to M70]Set default value for buttons and eol state.

Currently button and eol states are pulled from C++ side.
In some broken state, c++ does not provide any information and about
page end up showing all 3 buttons and eol state at the same time.

TBR=dpapad@chromium.org

(cherry picked from commit ac531badbf2aa7af4727d4699f909e3c251ff675)

Bug:  883900 
Change-Id: I70788e3c3634dd11586c515c89ef499409d155e5
Reviewed-on: https://chromium-review.googlesource.com/1247185
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594910}
Reviewed-on: https://chromium-review.googlesource.com/1252144
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#739}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/1b4357a529bd46ab097f6330c8648e8f80f5cfa8/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/1b4357a529bd46ab097f6330c8648e8f80f5cfa8/chrome/test/data/webui/settings/about_page_tests.js

Status: Fixed (was: Assigned)
Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/1b4357a529bd46ab097f6330c8648e8f80f5cfa8

Commit: 1b4357a529bd46ab097f6330c8648e8f80f5cfa8
Author: xiaoyinh@chromium.org
Commiter: xiaoyinh@chromium.org
Date: 2018-09-28 17:49:10 +0000 UTC

[Merge to M70]Set default value for buttons and eol state.

Currently button and eol states are pulled from C++ side.
In some broken state, c++ does not provide any information and about
page end up showing all 3 buttons and eol state at the same time.

TBR=dpapad@chromium.org

(cherry picked from commit ac531badbf2aa7af4727d4699f909e3c251ff675)

Bug:  883900 
Change-Id: I70788e3c3634dd11586c515c89ef499409d155e5
Reviewed-on: https://chromium-review.googlesource.com/1247185
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594910}
Reviewed-on: https://chromium-review.googlesource.com/1252144
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#739}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Sign in to add a comment