New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883897 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , iOS , Mac
Pri: 3
Type: Bug

Blocking:
issue 880827



Sign in to add a comment

mac and ios tot bots failing compile

Project Member Reported by thakis@chromium.org, Sep 13

Issue description

https://ci.chromium.org/buildbot/chromium.clang/ToTMacASan/1454

clang regression range on that bot is 342071:342102


FAILED: obj/third_party/webrtc/pc/rtc_pc_base/dtlssrtptransport.o 
export DEVELOPER_DIR=/b/c/b/ToTMac__dbg_/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/pc/rtc_pc_base/dtlssrtptransport.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"342146\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DWEBRTC_ENABLE_PROTOBUF=1 -DHAVE_SCTP -DENABLE_EXTERNAL_AUTH -DUSE_BUILTIN_SW_CODECS -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DHAVE_SCTP -DNO_MAIN_THREAD_WRAPPING -DPACKAGE_STRING=\"libsrtp2\ 2.1.0-pre\" -DPACKAGE_VERSION=\"2.1.0-pre\" -DHAVE_CONFIG_H -DOPENSSL -DHAVE_STDLIB_H -DHAVE_STRING_H -DHAVE_STDINT_H -DHAVE_INTTYPES_H -DHAVE_INT16_T -DHAVE_INT32_T -DHAVE_INT8_T -DHAVE_UINT16_T -DHAVE_UINT32_T -DHAVE_UINT64_T -DHAVE_UINT8_T -DHAVE_ARPA_INET_H -DHAVE_NETINET_IN_H -DHAVE_SYS_TYPES_H -DHAVE_UNISTD_H -DBORINGSSL_SHARED_LIBRARY -I../.. -Igen -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../third_party/libyuv/include -I../../third_party/libsrtp -I../../third_party/libsrtp/config -I../../third_party/libsrtp/include -I../../third_party/libsrtp/crypto/include -I../../third_party/boringssl/src/include -fno-strict-aliasing -fstack-protector-strong -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -O0 -fno-omit-frame-pointer -gdwarf-2 -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wglobal-constructors -Wno-shorten-64-to-32 -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../third_party/webrtc/pc/dtlssrtptransport.cc -o obj/third_party/webrtc/pc/rtc_pc_base/dtlssrtptransport.o
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.cc:11:
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.h:14:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/memory:653:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/type_traits:406:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/cstddef:38:
../../third_party/libsrtp/version:1:1: error: expected unqualified-id
2.2.0-pre
^
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.cc:11:
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.h:14:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/memory:653:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/type_traits:406:
../../third_party/llvm-build/Release+Asserts/include/c++/v1/cstddef:50:9: error: no member named 'ptrdiff_t' in the global namespace
using ::ptrdiff_t;
      ~~^
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.cc:11:
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.h:14:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/memory:653:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/type_traits:407:
../../third_party/libsrtp/version:1:1: error: expected unqualified-id
2.2.0-pre
^
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.cc:11:
In file included from ../../third_party/webrtc/pc/dtlssrtptransport.h:14:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/memory:654:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/typeinfo:61:
In file included from ../../third_party/llvm-build/Release+Asserts/include/c++/v1/exception:84:
../../third_party/libsrtp/version:1:1: error: expected unqualified-id
2.2.0-pre
^



/third_party/libsrtp/VERSION contains just "2.2.0-pre"

Upstream 342073 added a "version" file to libc++ and a bunch of #include <version> lines; mac has a case-insensitive file system and probably picks up the libsrtp/VERSION file instead of the new version file in libc++.
 
Cc: kjellander@chromium.org mattdr@chromium.org phoglund@chromium.org
+libsrtp owners. Is there a chance to either remove -I../../third_party/libsrtp or to a) rename the VERSION file to something else b) put it in a directory not on the search path?
Owner: mbonadei@chromium.org
Status: Assigned (was: Untriaged)
Mirko, can you take a look? I think we can just rename VERSION to LIBSRTP_VERSION for instance.

Also remove kjellander from owners since he left the company.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/libsrtp/+/376772a4103db3ccd3ffbdce604a6b60ce926dd0

commit 376772a4103db3ccd3ffbdce604a6b60ce926dd0
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Fri Sep 14 08:19:00 2018

Rename VERSION to avoid issues with libc++.

Upstream 342073 added a "version" file to libc++ and a bunch of
#include <version> lines; mac has a case-insensitive file system and
probably picks up the libsrtp/VERSION because of
-I../../third_party/libsrtp.

Bug:  883897 
Change-Id: Ib2e708038e7c170a83ee28a4e5a16883c8a55cf6

[rename] https://crrev.com/376772a4103db3ccd3ffbdce604a6b60ce926dd0/LIBSRTP_VERSION
[modify] https://crrev.com/376772a4103db3ccd3ffbdce604a6b60ce926dd0/README.chromium

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd60481ec1c27e8db97497c7e67f93dfb665b9d4

commit cd60481ec1c27e8db97497c7e67f93dfb665b9d4
Author: Mirko Bonadei <mbonadei@chromium.org>
Date: Fri Sep 14 11:41:11 2018

Bump libsrtp version 368abd6bb3 -> 650611720e.

Not a real change to libsrtp itself but just a rename of
//third_party/libsrtp/VERSION to //third_party/libsrtp/LIBSRTP_VERSION
in order to avoid issues with libc++.

Bug:  883897 
Change-Id: Iccd0dcc5ee1e3e9339ecbf96f3b6d7844d8fc135
Reviewed-on: https://chromium-review.googlesource.com/1225873
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591323}
[modify] https://crrev.com/cd60481ec1c27e8db97497c7e67f93dfb665b9d4/DEPS

Status: Fixed (was: Started)
Thanks!

Sign in to add a comment