Issue metadata
Sign in to add a comment
|
Better Together top-level item is showing in Settings when it shouldnt |
||||||||||||||||||||||||
Issue descriptionObserved on head. My Pixelbook had not enrolled in ~10 days (before I put this particular test account on a phone with the appropriate device flags), so presumably did not have BetterTogetherClient=kSupported. However, the top level Better Together item was visible in Settings, allowing me to incorrectly go through setup flow all the way. Logs attached. Unfortunately they're diluted by multiple setup flow attempts. Only pay attention to the latter part of the logs.
,
Sep 13
Sorry, this is actually not a full duplicate. Issue 870770 deals with the logic behind the scenes that deals with enrolling the device. Looking at the attached logs, it's clear that the device was not actually enrolled successfully. However, if the device is not enrolled (and thus does not have support for MultiDevice setup), the UI should not display the section. Let's dedicate this bug to that UI issue.
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1911356ee579a0cfbc8f2f84283437defbe92983 commit 1911356ee579a0cfbc8f2f84283437defbe92983 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Mon Sep 17 19:04:58 2018 [CrOS MultiDevice] Add logs for debugging setting page content logic. Because the most complex logic in our settings page surrounds the page content retrieval IPCs, we've had a hard time debugging issues such as https://bugs.chromium.org/p/chromium/issues/detail?id=883893 The logging added in this CL will make it substantially easier to debug this (assuming it's not resolved by the next occurrence) and future issues. The changes include: -A log of the initial page content dictionary retrieved as a MultiDevicePageContentData object by the settings page -A log of the new feature state maps upon a feature change -A log to mark when a new page content update is sent and log the pageContentData Bug: 883893 Change-Id: I7775de0ec58104498956b358d5e77cc221028c47 Reviewed-on: https://chromium-review.googlesource.com/1227362 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#591762} [modify] https://crrev.com/1911356ee579a0cfbc8f2f84283437defbe92983/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc [modify] https://crrev.com/1911356ee579a0cfbc8f2f84283437defbe92983/chromeos/services/multidevice_setup/feature_state_manager.cc [modify] https://crrev.com/1911356ee579a0cfbc8f2f84283437defbe92983/chromeos/services/multidevice_setup/feature_state_manager.h [modify] https://crrev.com/1911356ee579a0cfbc8f2f84283437defbe92983/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
,
Sep 20
,
Sep 20
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by khorimoto@chromium.org
, Sep 13Status: Duplicate (was: Available)