New issue
Advanced search Search tips

Issue 883892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

memory.leak_detection failing on chromium.linux/Leak Detection Linux

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 13

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of adithyas@chromium.org

memory.leak_detection failing on chromium.linux/Leak Detection Linux

Builders failed on: 
- Leak Detection Linux: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux


 
Cc: skobes@chromium.org
Owner: npm@chromium.org
Status: Assigned (was: Available)
Suspecting: https://chromium-review.googlesource.com/c/chromium/src/+/1222866 which was part of the first the failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux/19248
Cc: npm@chromium.org
Owner: u...@chromium.org
It looks like it's crashing during the test, stacktrace:
Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 126, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 300, in RunStory
    self._current_page.Run(self)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/__init__.py", line 95, in Run
    shared_state.page_test.RunNavigateSteps(self, current_tab)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/legacy_page_test.py", line 152, in RunNavigateSteps
    page.RunNavigateSteps(action_runner)
  File "/b/s/w/ir/tools/perf/contrib/leak_detection/page_sets.py", line 29, in RunNavigateSteps
    self._WaitForPageLoadToComplete(new_tab.action_runner)
  File "/b/s/w/ir/tools/perf/contrib/leak_detection/page_sets.py", line 36, in _WaitForPageLoadToComplete
    py_utils.WaitFor(action_runner.tab.HasReachedQuiescence, timeout=30)
  File "/b/s/w/ir/third_party/catapult/common/py_utils/py_utils/__init__.py", line 136, in WaitFor
    res = condition()
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 137, in HasReachedQuiescence
    script=self._quiescence_js)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 215, in EvaluateJavaScript
    return self._inspector_backend.EvaluateJavaScript(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 253, in EvaluateJavaScript
    return self._EvaluateJavaScript(expression, context_id, timeout)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 38, in Inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 535, in _EvaluateJavaScript
    return self._runtime.Evaluate(expression, context_id, timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 44, in Evaluate
    res = self._inspector_websocket.SyncRequest(request, timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 132, in SyncRequest
    res = self._Receive(timeout)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 190, in _Receive
    self._HandleNotification(result)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 203, in _HandleNotification
    self._domain_handlers[domain_name](result)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_log.py", line 26, in _OnMessage
    entry['source'], entry['text'], entry['url'])
KeyError: 'url'

Probably https://chromium-review.googlesource.com/c/catapult/+/1220366. ulan@ could you take a look?
I've stopped the autoroll bot for now since https://chromium-review.googlesource.com/c/catapult/+/1220366 looks like the culprit CL.
Roll was reverted. Going to see if that fixes things
Labels: -Sheriff-Chromium
Revert seems to have worked.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/79d6b805c023a98e83689beb3d0ae9de63881f85

commit 79d6b805c023a98e83689beb3d0ae9de63881f85
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Fri Sep 14 09:19:00 2018

Revert "Output DevTools error messages as warnings while running a story."

This reverts commit 1af2b3bcd6c973d60f588b00c75c6b5049ee8c8a.

Reason for revert: blocking roll 
Bug:  chromium:883892 

Original change's description:
> Output DevTools error messages as warnings while running a story.
> 
> Bug: chromium:880432
> Change-Id: I2367a17d3ea1739a015ccb381479ad12eb1ae831
> Reviewed-on: https://chromium-review.googlesource.com/1220366
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>

TBR=ulan@chromium.org,perezju@chromium.org,nednguyen@google.com,cbruni@chromium.org

Change-Id: I1c8d91564f7def004fa942b906f88076f1100c12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:880432
Reviewed-on: https://chromium-review.googlesource.com/1225894
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>

[delete] https://crrev.com/5d54982d7abcc9d602ac4cc4decf214065c387f0/telemetry/telemetry/internal/backends/chrome_inspector/inspector_log.py
[modify] https://crrev.com/79d6b805c023a98e83689beb3d0ae9de63881f85/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35

commit 8323f92cb0c81332c00abfe5a3bad012a400fd35
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 14 16:52:21 2018

Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits)

https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813


git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle
2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story."
2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads
2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws.
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner
2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug
2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions
2018-09-13 pasko@chromium.org clear_system_cache: update binaries
2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG.
2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.


Created with:
  gclient setdep -r src/third_party/catapult@9f36d9f78813

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
TBR=sullivan@chromium.org

Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861
Reviewed-on: https://chromium-review.googlesource.com/1226380
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591375}
[modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS

I saw 2 failures in the last hour at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux

I'm seeing HTTP errors 500 and 404 in the log. Is this expected?

  [ RUN      ] memory.leak_detection/http://www.bestdic.ir
  (WARNING) 2018-09-28 11:45:30,518 inspector_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 500 (Internal Server Error) http://www.bestdic.ir/
  [       OK ] memory.leak_detection/http://www.bestdic.ir (9969 ms)
  [ RUN      ] memory.leak_detection/http://www.privacyassistant.net
  (WARNING) 2018-09-28 11:45:40,480 inspector_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 500 (Internal Server Error) http://www.privacyassistant.net/
  [       OK ] memory.leak_detection/http://www.privacyassistant.net (9973 ms)
  [ RUN      ] memory.leak_detection/http://www.sklavenzentrale.com
  [       OK ] memory.leak_detection/http://www.sklavenzentrale.com (10502 ms)
  [ RUN      ] memory.leak_detection/http://www.podbay.fm
  (WARNING) 2018-09-28 11:46:00,969 inspector_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 404 (Not Found) http://podbay.fm/html/
  [       OK ] memory.leak_detection/http://www.podbay.fm (10587 ms)
  [ RUN      ] memory.leak_detection/http://www.coco.fr
  [       OK ] memory.leak_detection/http://www.coco.fr (10294 ms)
  [ RUN      ] memory.leak_detection/http://www.skipaas.com
  [       OK ] memory.leak_detection/http://www.skipaas.com (10375 ms)
  [ RUN      ] memory.leak_detection/http://www.chatword.org
  (WARNING) 2018-09-28 11:46:32,218 inspector_log._OnMessage:26  DevTools console [network]: Failed to load resource: the server responded with a status of 500 (Internal Server Error) http://www.chatword.org/
fdoray@, we now surface the Chrome console errors to the log output.

The errors shows that something is off with the recorded WPR archive.

Status: Fixed (was: Assigned)
The issue in Comment 2 is fixed.

I filed a separate issue for Comment 8: crbug.com/890716

Sign in to add a comment