New issue
Advanced search Search tips

Issue 883888 link

Starred by 4 users
Status: Verified
Owner:
hbos@chromium.org
Closed: Oct 12
Cc:
hbos@chromium.org
hta@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 857003
issue 893471
issue 894763



Sign in to add a comment

webrtc: sdpSemantics: unified-plan breaks onaddstream

Project Member Reported by philipp....@googlemail.com, Sep 13 
Chrome Version: 69 as well as unstable
OS: linux

What steps will reproduce the problem?
(1) go to https://webrtc.github.io/
(2) paste this into the console
const pc = new RTCPeerConnection({sdpSemantics: 'unified-plan'});
const pc2 = new RTCPeerConnection({sdpSemantics: 'unified-plan'});
pc2.onaddstream = (e) => console.log('onaddstream', e);
pc2.ontrack = (e) => console.log('ontrack', e);

navigator.mediaDevices.getUserMedia({video: true})
.then(stream => pc.addStream(stream))
.then(() => pc.createOffer())
.then((offer) => pc2.setRemoteDescription(offer))

What is the expected result?
both onaddstream and ontrack are triggered

What happens instead?
only ontrack is triggered

Comment 1 by hbos@chromium.org, Sep 14

Labels: -Pri-3 M-71 Pri-2
Status: Assigned (was: Untriaged)
The "if you're gonna do it the spec way, don't rely on legacy APIs" argument does not hold if the default is switching and we don't want to break legacy apps that "don't care about SDP semantics".

Comment 2 by philipp....@googlemail.com, Sep 14

Blocking: 857003

Comment 3 by philipp....@googlemail.com, Sep 14 

Breaking without any deprecation notice when setting onaddstream is clearly bad.

Comment 4 by hbos@chromium.org, Oct 10

Cc: hta@chromium.org
Owner: hbos@chromium.org
Status: Started (was: Assigned)
Almost forgot about this one :)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ce7dc957431d3b6ba9238933afb4ec74543514

commit 42ce7dc957431d3b6ba9238933afb4ec74543514
Author: Henrik Boström <hbos@chromium.org>
Date: Wed Oct 10 17:32:37 2018

Fire legacy onaddstream/onremovestream in Unified Plan.

When switching the default sdpSemantics, we don't want to break
applications that use legacy APIs unnecessarily if they don't care about
Plan B vs Unified Plan stuff.

Bug:  883888 
Change-Id: I8b752b939838d56ee191efb53b7ce93301cb0820
Reviewed-on: https://chromium-review.googlesource.com/c/1273068
Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598386}
[add] https://crrev.com/42ce7dc957431d3b6ba9238933afb4ec74543514/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-legacy-stream-events.https.html
[modify] https://crrev.com/42ce7dc957431d3b6ba9238933afb4ec74543514/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc

Comment 6 by hbos@chromium.org, Oct 12

Status: Verified (was: Started)

Comment 7 by hbos@chromium.org, Oct 12

Blocking: 894763

Comment 8 by hbos@chromium.org, Oct 12

Blocking: 893471
►

Sign in to add a comment