[Harmony UI] Cast toolbar icon is not displayed in a new Chrome window even though the "Always show" option is selected. |
||||||
Issue descriptionChrome Version: 71.0.3551.0 OS: Win, Mac, CrOS MR:7118.910.0.0 The Cast toolbar icon is not displayed in a new Chrome window even though the "Always show" option is selected. Note that this is especially an issue when there is an active cast session. For example, drag the active casting tab out to a new window, and the blue active cast icon disappears. This does not occur with the WebUI. What steps will reproduce the problem? (1) Enable the #views-cast-dialog flag (2) Open the MR dialog, right click on the icon in the toolbar and select "Always show" (if it isn't already selected). (3) Open a new window. What is the expected result? Cast icon should be displayed in the new window's toolbar. What happens instead? The new window does not have a cast icon in the toolbar.
,
Sep 13
,
Sep 13
,
Sep 14
,
Sep 17
It seems to have gotten worse. Using the current dev channel build, I can't get the Cast icon to show up at all when the views-cast-dialog flag is enabled.
,
Sep 18
Plot twist: it seems I was testing with a problem that was opted into an experiment that interacts with this bug. When I used a different profile, I can repro the issue just fine.
,
Sep 18
s/problem/profile/
,
Sep 19
I have a hunch this is related to the icon being moved to the trusted area in the taskbar.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/228321ca7476e0febc56914623e9c1c863e86063 commit 228321ca7476e0febc56914623e9c1c863e86063 Author: John Williams <jrw@google.com> Date: Fri Oct 05 21:32:36 2018 Set visibility of Cast button for new Chrome windows. Bug: 883887 Change-Id: I9ce93c85e7fcfb2ad4625fe35abb3b8ee9fa2fd5 Reviewed-on: https://chromium-review.googlesource.com/c/1260103 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597309} [modify] https://crrev.com/228321ca7476e0febc56914623e9c1c863e86063/chrome/browser/ui/toolbar/media_router_action_controller.cc [modify] https://crrev.com/228321ca7476e0febc56914623e9c1c863e86063/chrome/browser/ui/toolbar/media_router_action_controller.h [modify] https://crrev.com/228321ca7476e0febc56914623e9c1c863e86063/chrome/browser/ui/views/media_router/cast_toolbar_button.cc
,
Oct 5
,
Oct 10
verified in 71.0.3573.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dbbrooks@chromium.org
, Sep 13