Clicking "Settings" at end of MultiDevice setup flow should close the flow |
|||||
Issue descriptionUpon finishing the setup flow, it prompts you with a link to settings: "Go to Settings to see your options...". Because the flow is *always* in the foreground, when the user clicks this Settings link, Settings opens in the background behind the flow (i.e., it is not visible). At this point in time, the user is no linger interested in the flow, so the flow UI should just be dismissed when this Settings link is tapped. This feels pretty unpolished / jarring, so I feel that it's not low priority. Screenshot attached.
,
Sep 13
SGTM
,
Sep 20
,
Sep 20
,
Sep 27
Currently (on HEAD), when I click "Settings", the setup flow is not dismissed but Settings is foregrounded at least. This doesn't feel too unnatural to me. Let me know if you are still seeing otherwise.
,
Sep 27
Re: comment #5: That behavior was changed via https://chromium-review.googlesource.com/c/chromium/src/+/1246787.
,
Sep 28
Good point Josh, I think this new behavior could at least lower the priority of the issue. However, the dialog should still be closed, for the reasons I listed in the summary.
,
Oct 3
,
Oct 10
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f7e90266307b6eb3ef85d60d8ec8f9a3c0875da commit 7f7e90266307b6eb3ef85d60d8ec8f9a3c0875da Author: Josh Nohle <nohle@google.com> Date: Wed Oct 10 01:49:33 2018 [CrOS MultiDevice] Close setup flow if Settings link is clicked If the "Settings" link is clicked on the setup-succeeded-page, close the setup flow UI. Bug: 883885 Change-Id: I5c93bff2c2ce1c4c9d9a01dbc470ad7bd4b8486a Tested: Manual, ./out/Default/browser_tests --gtest_filter=*MultiDevice* Reviewed-on: https://chromium-review.googlesource.com/c/1258577 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#598171} [modify] https://crrev.com/7f7e90266307b6eb3ef85d60d8ec8f9a3c0875da/chrome/test/data/webui/multidevice_setup/integration_test.js [modify] https://crrev.com/7f7e90266307b6eb3ef85d60d8ec8f9a3c0875da/ui/webui/resources/cr_components/chromeos/multidevice_setup/setup_succeeded_page.js |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hansberry@chromium.org
, Sep 13