New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 883882 link

Starred by 1 user
Status: Fixed
Owner:
tbroch@chromium.org
Closed: Oct 10
Cc:
derat@chromium.org
█ alberto@chromium.org
█ ggranito@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 894114



Sign in to add a comment

power: decrease plugged_suspend_ms from 30min to 8.5min

Project Member Reported by tbroch@chromium.org, Sep 13 
currently plugged_suspend_ms is 30min which I believe was an artifact of the maximum time allowed for a particular compliance/certification program (estar, eu, cec).

Given finding here:  crbug.com/782725  the time between 'screen off' and 'suspend' can be minimized w/o any user impact.

For that reason I would like to lower plugged_suspend_ms significantly.  This will likely result in ~4x power saving for the time between off & suspend (currently 22.5min).  

I'd propose maximizing the savings in a similar fashion to unplugged by making the delta 1min

So

  plugged_off_ms 450000       /* unchanged */
  plugged_suspend_ms 570000

Any concerns?

Comment 1 by derat@chromium.org, Sep 13

Cc: derat@chromium.org
I'm fully supportive of this.

And just to mention: like last time, both the powerd pref and the Chrome pref need to be updated. The Chrome pref is the important one; powerd's default is just used if Chrome isn't running for some reason.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83758eb6d94f412f013738b64a3cd71f4f11cfb

commit f83758eb6d94f412f013738b64a3cd71f4f11cfb
Author: Todd Broch <tbroch@chromium.org>
Date: Tue Oct 09 19:42:00 2018

chromeos: power: decrease default AC idle suspend time from 30 to 8.5 minutes.

AcIdleDelayMs = 510000 (from 30 -> 8.5min)

BUG=  883882 
TEST=manual

Change-Id: Iff600f1c06f0d4fdb992357b9d1827ce4dc80907
Reviewed-on: https://chromium-review.googlesource.com/c/1269634
Commit-Queue: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598041}
[modify] https://crrev.com/f83758eb6d94f412f013738b64a3cd71f4f11cfb/ash/system/power/power_prefs.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/43efda43884b4565f35b2dbc36008ffbcf884982

commit 43efda43884b4565f35b2dbc36008ffbcf884982
Author: Todd Broch <tbroch@chromium.org>
Date: Wed Oct 10 12:19:41 2018

power: decrease default AC idle suspend time from 30 to 8.5 minutes.

plugged_ms_off = 510000 (from 30 -> 8.5min)

BUG= chromium:883882 
TEST=manual

Change-Id: Ide3c4c889abcf43f8f29cea80fe85ad8fa9e746e
Reviewed-on: https://chromium-review.googlesource.com/1269692
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/43efda43884b4565f35b2dbc36008ffbcf884982/power_manager/docs/inactivity_delays.md
[modify] https://crrev.com/43efda43884b4565f35b2dbc36008ffbcf884982/power_manager/default_prefs/plugged_suspend_ms

Comment 4 by tbroch@chromium.org, Oct 10

Status: Fixed (was: Assigned)

Comment 5 by tbroch@chromium.org, Oct 10

Summary: power: decrease plugged_suspend_ms from 30min to 8.5min (was: power: decrease plugged_suspend_ms from 30min to ?)

Comment 6 by djmm@chromium.org, Oct 11

Blocking: 894114
►

Sign in to add a comment