New issue
Advanced search Search tips

Issue 883873 link

Starred by 2 users
Status: Fixed
Owner:
weidongg@chromium.org
Closed: Sep 17
Cc:
ajha@chromium.org
weidongg@chromium.org
newcomer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Homecher suggestion chip label text has black artifacts

Project Member Reported by xiy...@chromium.org, Sep 13 
Chrome version: 70.0.3530.0 on samus. See attached screenshot.

We probably need to call Label::SetSubpixelRenderingEnabled(false) in homechar since the text is rendered onto transparency.
suggestion_chip_label.png
1.6 MB View Download

Comment 1 by newcomer@chromium.org, Sep 13

Labels: -Pri-2 Pri-1

Comment 2 by weidongg@chromium.org, Sep 13 

It seems to be related to the breaking text issue we had before [1]. It's also device specific and occured on samus. Thanks for the suggestion, I will try Label::SetSubpixelRenderingEnabled(false) on samus.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=746563

Comment 3 by weidongg@chromium.org, Sep 13 

hmm, samus does not seems to have tablet mode. Is there a way to trigger it without hacking code?

Comment 4 by weidongg@chromium.org, Sep 13 

Oh, I see, I found the flag: #force-tablet-mode. and managed to repro that.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c614ed4ce1a1f441641e425dfc0372f31ed897ef

commit c614ed4ce1a1f441641e425dfc0372f31ed897ef
Author: Weidong Guo <weidongg@chromium.org>
Date: Thu Sep 13 23:40:54 2018

Fix broken suggestion chip text in samus

Bug:  883873 
Change-Id: I50d4059b22cd8baefeebabc44e8c128c2efb7374
Reviewed-on: https://chromium-review.googlesource.com/1225865
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591211}
[modify] https://crrev.com/c614ed4ce1a1f441641e425dfc0372f31ed897ef/ash/app_list/views/suggestion_chip_view.cc

Comment 6 by weidongg@chromium.org, Sep 13

Labels: Merge-Request-70

Comment 7 by geo...@google.com, Sep 14

Labels: -Merge-Request-70 Merge-Approved-70

Comment 8 by weidongg@chromium.org, Sep 17

Cc: weidongg@chromium.org ajha@chromium.org
 Issue 884153  has been merged into this issue.

Comment 9 by weidongg@chromium.org, Sep 17

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 17

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd5fe09ddcf374decc5a24e848b06a77fbec6acf

commit cd5fe09ddcf374decc5a24e848b06a77fbec6acf
Author: Weidong Guo <weidongg@chromium.org>
Date: Mon Sep 17 22:12:35 2018

Fix broken suggestion chip text in samus

Bug:  883873 
Change-Id: I50d4059b22cd8baefeebabc44e8c128c2efb7374
Reviewed-on: https://chromium-review.googlesource.com/1225865
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591211}(cherry picked from commit c614ed4ce1a1f441641e425dfc0372f31ed897ef)
Reviewed-on: https://chromium-review.googlesource.com/1229159
Cr-Commit-Position: refs/branch-heads/3538@{#465}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/cd5fe09ddcf374decc5a24e848b06a77fbec6acf/ash/app_list/views/suggestion_chip_view.cc
►

Sign in to add a comment