New issue
Advanced search Search tips

Issue 883863 link

Starred by 4 users
Status: Duplicate
Merged: issue 868398
Owner:
weili@chromium.org
Closed: Sep 14
Cc:
sdy@chromium.org
robliao@chromium.org
chrome-conops-escalation@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MacViews] [User Feedback - Stable] Command+L Doesn't Reveal Omnibox in fullscreen (when “Always show toolbar in full screen mode“ unchecked)

Project Member Reported by craigtumblison@chromium.org, Sep 13 
Chrome Version: 69.0.3497.92

Hey all,

We're seeing reports that the Command+L shortcut doesn't work. We can reproduce with MacViews enabled, and it doesn't reproduce with MacViews disabled.

Reports:
- https://listnr.corp.google.com/report/85653960030
- https://listnr.corp.google.com/report/85636507099
- https://listnr.corp.google.com/report/85640754466
- https://listnr.corp.google.com/report/85644427755

Community:
- https://productforums.google.com/forum/#!topic/chrome/C3bwww8vbd4

Note that most of the reports mention this being most useful in fullscreen mode.

Thanks!

Comment 1 by meh...@chromium.org, Sep 13

Components: UI>Browser>Omnibox UI>Input>KeyboardShortcuts
Labels: -Pri-3 Pri-2

Comment 2 by skare@chromium.org, Sep 13

Cc: robliao@chromium.org
Owner: robliao@chromium.org
Status: Assigned (was: Unconfirmed)
->hi robliao@ does this repro and make sense? Don't have a mac charged at the moment.

Comment 3 by tapted@chromium.org, Sep 14

Labels: -Type-Bug Type-Bug-Regression
Owner: weili@chromium.org
Summary: [MacViews] [User Feedback - Stable] Command+L Doesn't Reveal Omnibox in fullscreen (when “Always show toolbar in full screen mode“ unchecked) (was: [MacViews] [User Feedback - Stable] Command+L Doesn't Focus Omnibox)
retitling after reading all the feedback reports - this seems to be the common element.

It's possible  Issue 879158  helped, but I suspect we need to port some code from Cocoa to make this happen.

Comment 4 by meh...@chromium.org, Sep 14

Cc: sdy@chromium.org
Probably a dupe of issue 868398.

Comment 5 by weili@chromium.org, Sep 14

Mergedinto: 868398
Status: Duplicate (was: Assigned)
The problem is when 'Always show toolbar in full screen mode' is unchecked, we don't show the top UI with slide down menu. Thus the hotkey has no effect. Merge into 868398.
►

Sign in to add a comment