New issue
Advanced search Search tips

Issue 883860 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: ----



Sign in to add a comment

external/.../interfaces-sw.https.html in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 13

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of adithyas@chromium.org

external/.../interfaces-sw.https.html in webkit_layout_tests failing on chromium.mac/Mac10.13 Tests (dbg)

Builders failed on: 
- Mac10.13 Tests (dbg): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29


 
Looks like the most recent WPT sync pulled a mac specific test expectation file for this test.
Commit in question: https://chromium.googlesource.com/chromium/src/+/18fec7eefade4918260ae43db81e2b0daf0c2ac1

I'm going to disable the test on Mac.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4fc55d50f7ed3bb2319219f62a45ecdfb8bd936

commit e4fc55d50f7ed3bb2319219f62a45ecdfb8bd936
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Sep 13 17:31:10 2018

Add failure expectation for interfaces-sw.https.html

Adds failure expectation on Mac only.

Tbr: nhiroki@chromium.org
No-Try: true
Bug:  883860 
Change-Id: Ib3c720bbc9ceadb788025180332a3c3f2ec33ba2
Reviewed-on: https://chromium-review.googlesource.com/1225097
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591057}
[modify] https://crrev.com/e4fc55d50f7ed3bb2319219f62a45ecdfb8bd936/third_party/WebKit/LayoutTests/TestExpectations

Cc: -adithyas@chromium.org
Components: Blink>ServiceWorker
Labels: -Sheriff-Chromium OS-Mac
Owner: nhiroki@chromium.org
Removing sheriff label, and reassigning to SW team to triage.
Status: Untriaged (was: Available)
Setting to Untriaged so it enters our team's triage process.
Owner: ----
Owner: bashi@chromium.org
Status: Assigned (was: Untriaged)
Will take a look next week.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1043dffa0d471a42531bafcd20bc0e6143140534

commit 1043dffa0d471a42531bafcd20bc0e6143140534
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue Oct 09 05:18:29 2018

service worker: Remove interface-sw.https.html expectation

Platform specific -expected.txt files are removed so we don't need
this entry.

Bug:  883860 
Change-Id: I489308a090603520adc14e7fb8a65412fb5404db
Reviewed-on: https://chromium-review.googlesource.com/c/1270209
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597806}
[modify] https://crrev.com/1043dffa0d471a42531bafcd20bc0e6143140534/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment