New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883837 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"http/tests/performance-timing/resource_timing_buffer_full_250.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 13

Issue description

"http/tests/performance-timing/resource_timing_buffer_full_250.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTQsSBUZsYWtlIkJodHRwL3Rlc3RzL3BlcmZvcm1hbmNlLXRpbWluZy9yZXNvdXJjZV90aW1pbmdfYnVmZmVyX2Z1bGxfMjUwLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Cc: npm@chromium.org
Owner: y...@yoav.ws
Status: Assigned (was: Untriaged)
The test just timeouts randomly. Been happening every month since the test was introduced, so probably there's something inherently flaky about the way the test is written?
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b13e48e9ab1da1bdcd67f0257ae3e13a1ba5ec4a

commit b13e48e9ab1da1bdcd67f0257ae3e13a1ba5ec4a
Author: Darren Shen <shend@chromium.org>
Date: Fri Sep 14 00:26:26 2018

[sheriff] Disable resource_timing_buffer_full_250.html on Win7.

Flaky time outs on Win7.

TBR=yoav@yoav.ws, npm@chromium.org

Bug: 883837
Change-Id: I11324b4e90c4f8f7938eb4f01941e0ce7e2225cf
Reviewed-on: https://chromium-review.googlesource.com/1226471
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591226}
[modify] https://crrev.com/b13e48e9ab1da1bdcd67f0257ae3e13a1ba5ec4a/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium

Comment 4 by y...@yoav.ws, Sep 24

Are these flakes limited to Win7? 
Could it be the test is just too slow so it times out sometimes on the slow bots? We could add ~260 (some number greater than 250) scripts all at the same time (instead of adding the second during the onload of the first etc) and the test should still work.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7845d4c72545de2f0dff8b240727ee6bed584c

commit 4e7845d4c72545de2f0dff8b240727ee6bed584c
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Oct 11 19:50:02 2018

Fix flakiness in resource_timing_buffer_full_250

This CL uses document fragments to append scripts faster. Also, we do
not need to wait until onload of one script to begin appending the next.

Bug: 626703, 883837
Change-Id: I0bc010640793d6a7113d404f2838fd5cfe88ab25
Reviewed-on: https://chromium-review.googlesource.com/c/1265901
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598896}
[modify] https://crrev.com/4e7845d4c72545de2f0dff8b240727ee6bed584c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4e7845d4c72545de2f0dff8b240727ee6bed584c/third_party/WebKit/LayoutTests/external/wpt/resource-timing/resource_timing_buffer_full_eventually.html
[modify] https://crrev.com/4e7845d4c72545de2f0dff8b240727ee6bed584c/third_party/WebKit/LayoutTests/http/tests/performance-timing/resource_timing_buffer_full_250.html

Let's leave this open for now to see if we get more flakes.

Sign in to add a comment