New issue
Advanced search Search tips

Issue 883832 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.5% regression in system_health.common_desktop at 590634:590648

Project Member Reported by npm@chromium.org, Sep 13

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=883832

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=951dc9566ee1ce35b9e5ae359a6565bb7f629edf236602580c231062cd15a4d2


Bot(s) for this bug's original alert(s):

mac-10_12_laptop_low_end-perf

system_health.common_desktop - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/123dfeb5640000
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/11966ceb640000
Cc: kojii@chromium.org
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/157706f7640000

[LayoutNG] Sync PaintBoxDecorationBackground with BoxPainter by kojii@chromium.org
https://chromium.googlesource.com/chromium/src/+/07172170d6f94704bd47389e39251e24b905baaa
572.6 → No values

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Cc: -kojii@chromium.org
Owner: ----
I don't think #7 is correct, the CL changes code that runs only when LayoutNG runtime flag is enabled, and the pinpoint seemed to have failed.

How can I run it again?
Go to the graphs -> click on the regression point -> bisect
I'll run it again but it looks like the graphs are recovering
Status: Untriaged (was: Assigned)
Cc: yoichio@chromium.org vovoy@chromium.org
Owner: vovoy@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/15edbd87640000

Change old and new selection representation to use Node instead of LayoutObject by yoichio@chromium.org
https://chromium.googlesource.com/chromium/src/+/3cb73e6590a6c6c4b34088196b77ed492f7b77ce
657.1 → 579 (-78.11)

Disable loading.desktop/AllRecipes_cold on ChromeOS by vovoy@chromium.org
https://chromium.googlesource.com/chromium/src/+/2de8f4f0f966637c76152b54aee275dcc49fbbb9
611.7 → 701.4 (+89.75)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
It is really unclear which score is better, lower or higher?
Lower is better (I don't see this info from Pinpoint but if you click at the graphs in #1 the graphs show this information
Owner: ----
Status: Available (was: Assigned)
"Disable loading.desktop/AllRecipes_cold on ChromeOS" disable a test on ChromeOS. It's very unlikyly to cause regression on Mac.
Owner: vovoy@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1527f313640000

Disable loading.desktop/AllRecipes_cold on ChromeOS by vovoy@chromium.org
https://chromium.googlesource.com/chromium/src/+/2de8f4f0f966637c76152b54aee275dcc49fbbb9
651.2 → 756.7 (+105.6)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Status: WontFix (was: Assigned)
The value went back to normal on 591963
https://chromeperf.appspot.com/group_report?bug_id=883832

"Disable loading.desktop/AllRecipes_cold on ChromeOS" should not affect Mac.
Dispersion of the graph is big. Is the perf test really trusty?

Sign in to add a comment