Issue metadata
Sign in to add a comment
|
12.6%-18.1% regression in system_health.common_mobile at 589801:589897 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 13
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/13de1407640000
,
Oct 16
The last try seems to detect r589877 as a suspicious CL, but for some reasons it wasn't reported here? Let me run another bisect just in case.
,
Oct 16
,
Oct 16
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12b7685ce40000
,
Oct 22
The last pinpoint job has ended the same way. It seems my CL is a culprit indeed. I'll take a look.
,
Oct 23
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/12b7685ce40000 custom elements: Replace ElementDefinitionIsRunning with base::AutoReset. by yukishiino@chromium.org https://chromium.googlesource.com/chromium/src/+/6bb20b5e1c97de7314331e3912fe0768eb65749d timeToFirstPaint: 1425 → 1374 (-51.04) predictors: Request a proxy lookup in parallel with host resolve request by alexilin@chromium.org https://chromium.googlesource.com/chromium/src/+/248c267fc1c931ba1863d72bb1ddbd45f8680218 timeToFirstPaint: 1374 → 1597 (+223) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Oct 25
My change "custom elements: Replace ElementDefinitionIsRunning with base::AutoReset." is a pretty simple and trivial refactoring and shouldn't be affecting performance. Looking at "timeToFirstPaint: 1425 → 1374 (-51.04)", it seems that my patch is irrelevant. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 13