Remove parameter serving_dirs in StorySet constructor |
|||
Issue descriptionStorySet constructor parameter serving_dirs is used in 3 places only, they can all be moved to page level. https://cs.chromium.org/search/?q=file:src/tools/perf+%22serving_dirs%3D Remove serving_dirs in StorySet constructor and use page level serving_dir only to simplify code.
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76ac6d9368131537b0b474819f440a3df3477e0d commit 76ac6d9368131537b0b474819f440a3df3477e0d Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Sep 14 08:26:26 2018 Remove serving_dirs usage in speedometer2 The serving dir is also included by the page. Bug: chromium:883798 Change-Id: I1d1a512774b69312642b6226a80023ac88ff3293 Reviewed-on: https://chromium-review.googlesource.com/1226752 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591301} [modify] https://crrev.com/76ac6d9368131537b0b474819f440a3df3477e0d/tools/perf/benchmarks/speedometer2.py
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c04854f4ff7ec8ad30e5e98ca59dc1930ea6b817 commit c04854f4ff7ec8ad30e5e98ca59dc1930ea6b817 Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Sep 14 09:31:07 2018 Remove serving_dirs usage in static_top_25_pages The serving dir is also included by the pages. Bug: chromium:883798 Change-Id: Ifb67e19b03303e4929a0e588f5450707adec4835 Reviewed-on: https://chromium-review.googlesource.com/1226484 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#591312} [modify] https://crrev.com/c04854f4ff7ec8ad30e5e98ca59dc1930ea6b817/tools/perf/page_sets/static_top_25_pages.py
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vovoy@chromium.org
, Sep 14