New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883735 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Dashboard - Fails on empty or uncompressed uploads but doesn't error out

Project Member Reported by simonhatch@chromium.org, Sep 13

Issue description

Got this from webrtc uploading uncompressed data, which was seemingly succeeding, just failing deeper in the backend. We should error out immediately.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/5d54982d7abcc9d602ac4cc4decf214065c387f0

commit 5d54982d7abcc9d602ac4cc4decf214065c387f0
Author: Simon <simonhatch@chromium.org>
Date: Thu Sep 13 21:52:09 2018

Dashboard - Error out on empty or uncompressed uploads

Bug:  chromium:883735 
Change-Id: If9c7011549d28f4fe393ee8975ff34f79f4ae4a3
Reviewed-on: https://chromium-review.googlesource.com/1224738
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/5d54982d7abcc9d602ac4cc4decf214065c387f0/dashboard/dashboard/add_histograms_test.py
[modify] https://crrev.com/5d54982d7abcc9d602ac4cc4decf214065c387f0/dashboard/dashboard/add_histograms.py

Owner: simonhatch@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35

commit 8323f92cb0c81332c00abfe5a3bad012a400fd35
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 14 16:52:21 2018

Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits)

https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813


git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle
2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story."
2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads
2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws.
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner
2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug
2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions
2018-09-13 pasko@chromium.org clear_system_cache: update binaries
2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG.
2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.


Created with:
  gclient setdep -r src/third_party/catapult@9f36d9f78813

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
TBR=sullivan@chromium.org

Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861
Reviewed-on: https://chromium-review.googlesource.com/1226380
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591375}
[modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS

Sign in to add a comment