Issue metadata
Sign in to add a comment
|
Bookmarkbar text contrast is different in material refresh
Reported by
stmagr1...@gmail.com,
Sep 13
|
|||||||||||||||||||||||||||||||||||||||
Issue description
Chrome Version : Version 69.0.3497.92 (Official Build) (64-bit)
URLs (if applicable) : Any, other browsers work.
Other browsers tested:
Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
Safari: OK, latest
Firefox: OK, latest
Edge: Didn't test Edge.
What steps will reproduce the problem?
(1) Open any website
(2) Look at fonts
(3) Blurred look
What is the expected result?
Non-blurred fonts
What happens instead?
Blurred fonts
Please provide any additional information below. Attach a screenshot if
possible.
,
Sep 13
,
Sep 13
Is it possible to take screenshot using 68 as well?
,
Sep 13
#3: I will try.
,
Sep 13
Thank you for filing the bug. I hav a screenshot on my Mac with M68. They look the same however.
,
Sep 13
Yes please
,
Sep 13
Mh, would it be valuable if I supply from my computer also a screenshot of M68? Best, S.
,
Sep 13
,
Sep 13
This is differnt from Issue 880513 which was caused due to native widget's window pixel misalignment. Mac does not use this so if Mac does have blurry fonts it is caused due to some other issue. However from the screenshot it doesnt look like the fonts are blurry. Marking this unconfirmed.
,
Sep 13
Thanks malaykeshav. stmagr1986: The screenshot doesn't appear to have blurry fonts, could you provide a screenshot showing the difference between what you see now and what you saw in 68? Thanks
,
Sep 13
,
Sep 14
,
Sep 14
#11: Here it is. Note Hybrid or Normal will fix it. Default does not work.
,
Sep 14
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14
#14 The two screenshots look exactly the same. Is there something specific I need to focus on?
,
Sep 14
Hello, the fonts are blurred more noticeably in the navigation bar and bookmarks tab bar, which is not shown here... sorry.
,
Sep 14
Could you please provide a screenshot showing the navigation bar? Thank you!
,
Sep 14
#18: Will provide.
,
Sep 14
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 14
,
Sep 15
,
Sep 15
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 17
,
Sep 17
Tried checking the issue on reported chrome version 69.0.3497.92 using Mac 10.13.1 with the below mentioned steps. 1. Launched Chrome 2. Created few sample bookmark folders 3. Checked "Show Bookmarks bar" Our Observations: ------------------ On reported version the font contract is little low when compared it with the chrome version 68.0.3440.106. Attaching the screenshot of the same for reference. @Reporter: Could you please have a look at the screenshot and let us know if "low contrast levels in fonts" is the issue being talked about....as both of them rendering similar look when zoomed in, apart from colour contrast. Any further inputs from your end may be helpful.
,
Sep 17
#25: In fact it is
,
Sep 17
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 18
As per the confirmation given by reporter in C#26 about C#25, Providing the Bisect Information. Issue is seen on the latest chrome version 71.0.3554.0 also, using Mac 10.13.1 and Windows 10. Note: Issue is not seen on Ubuntu 14.04 Bisect Information: ------------------- Good Build: 69.0.3480.0 Bad Build: 69.0.3481.0 Providing the Changelog from https://omahaproxy.appspot.com/ as we couldn't get the relevant CL after performing per-revision bisect. https://chromium.googlesource.com/chromium/src/+log/69.0.3480.0..69.0.3481.0?pretty=fuller&n=10000 Suspecting: https://chromium.googlesource.com/chromium/src/+/79c4dc9d0916a74430ce84c2d39d8360ca3a902a Review URL: https://chromium-review.googlesource.com/1123456 @Christopher Cameron: Please help in assigning it to the right owner if this is not related to your change. Adding RB-Stable as this seems to be a recent regression, Please remove if not required. Thanks!
,
Sep 18
On further investigation observed that 69.0.3480.0 is being launched without material refresh and version 69.0.3481.0 being launched with material refresh. Hence cc'ing Robert Liao for further inputs, from the author of CL https://chromium.googlesource.com/chromium/src/+/1be226e1a5668c6c05627afb95383fb259d51ee2 as the issue is observed/gone with default/Hybrid of flag #top-chrome-md respectively (....mentioned in C#14). Thanks!
,
Sep 18
Redirecting to malaykeshav@chromium.org based off of http://crbug.com/880513
,
Sep 18
#30 This is not related to Issue 880513 which was resulting in blurry text in the web content. Mac does not use the framework that was causing that blurriness. The bug here is that the text in top view container has a contrast that is different in material refresh. If this is a part of the redesign or not I am not sure.
,
Sep 18
back to the owner prior to #30.
,
Sep 18
,
Sep 18
I'm not seeing the difference here ... - In #25 that's MD Refresh versus not, so I don't think they're supposed to look the same - In #22 it looks washed out ... and what are the versions in question? Is it MD Refresh again? What's the status of the bisect in #28 -- the comment in #29 suggests that it's not valid (was finding MD refresh being enabled). ->robliao (sorry for the hot-potato-ing) ... is this just a "MD refresh is lower contrast" bug.
,
Sep 18
Assigning to bettes@ for design evaluation now that this is a contrast issue.
,
Sep 18
Dropping RBS (I missed that it was). This was an intentional change which has the unfortunate effect of reducing the contrast. We're looking into ways to fixing this in the future release, but this shouldn't block the stable rollout.
,
Sep 18
,
Sep 19
#36: Thanks for taking care of this.
,
Sep 20
The NextAction date has arrived: 2018-09-20
,
Sep 20
,
Sep 26
,
Sep 26
,
Sep 27
,
Sep 27
bettes: Can you add the new colors here?
,
Sep 27
,
Sep 28
,
Sep 28
,
Sep 28
,
Oct 4
Plan of record: change to GG800
,
Oct 8
Assigning to cyan@ due to proximity to Bookmarks and at dfried@'s request. The request here is to change the bookmark bar color to GG800 or equivalent. Let us know if anything is unclear on the bug. Thanks!
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e76a0b49fc457a4554028a20ca24fa11b32bb3fa commit e76a0b49fc457a4554028a20ca24fa11b32bb3fa Author: Charlene Yan <cyan@chromium.org> Date: Mon Oct 08 23:58:14 2018 Changing bookmark text color from GG700 to GG800 Trivial color change. Bug: 883726 TBR: pkasting@chromium.org Change-Id: Ib4d24ac86cb3e2ccc4a80d6f5be9770ce170d62e Reviewed-on: https://chromium-review.googlesource.com/c/1269441 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#597743} [modify] https://crrev.com/e76a0b49fc457a4554028a20ca24fa11b32bb3fa/chrome/browser/themes/theme_properties.cc
,
Oct 10
Tried checking the issue on chrome version 71.0.3575.0 using Mac 10.13.1 when flag #top-chrome-md is set to default. Still didn't observe any significant change in contrast of bookmarked folder(s) in bookmark bar. Attaching the screenshot of the same for reference. @Charlene Yan: Could you please have a look at the screen shot and let us know if anything missed from our end in the process and requesting you to help us in verifying the fix. Thanks!
,
Oct 10
It is not significant, but the text does appear darker to me in the screenshot attached in comment #52 compared to the screenshot on the right in comment #25
,
Oct 11
,
Oct 16
,
Oct 16
The RBG values from a color picker on the screenshot from comment #25 on version 69.0.3497.92 is 96,99,104 whereas the from comment #52 on version 71.0.3575.0 is 61,64,67
,
Nov 20
***Mass UI Triage*** As per comments
,
Dec 11
,
Dec 13
Hello, latest version Version 71.0.3578.98 (Official Build) (64-bit) looks for me fine. I use default for #top-chrome-md but the other 3 also work fine. Best wishes, SG
,
Dec 13
|
||||||||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 13