New issue
Advanced search Search tips

Issue 883711 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Disclosure arrow ▼ in <input type=date> and <details> doesn't change color when transition is set

Reported by ni...@blazingedge.io, Sep 13

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.92 Safari/537.36

Steps to reproduce the problem:
https://codepen.io/anon/pen/eLKdem

1. Create input of type="date"
2. Add transition rule to that input (example: transition: all 5s)
3. Change a color of input on hover
4. Input changes the color, but caret down doesn't

What is the expected behavior?
When we change the color of the date input that has a transition rule set, the color of caret down should follow that rule and transition accordingly.

What went wrong?
Instead, it won't follow the transition rule and it will only change color to ending color if you hover over it or manipulate the input. If transition rule is removed it would work. It doesn't matter how short the transition duration is, once it is set, caret doesn't change color.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 69.0.3497.92  Channel: stable
OS Version: OS X 10.13.6
Flash Version:
 
Components: -Blink>CSS Blink>Forms>Date
Components: Blink>HTML>Details Blink>Paint
Labels: -Pri-2 Pri-3
Status: Untriaged (was: Unconfirmed)
Summary: Disclosure arrow ▼ in <input type=date> and <details> doesn't change color when transition is set (was: Caret down in input of date type doesn't change color when transition is set)
Might be an issue of blink::DetailsMarkerPainter.

Cc: susan.boorgula@chromium.org
 Issue 882462  has been merged into this issue.
Components: -Blink>Paint Blink>Paint>Invalidation
Owner: f...@opera.com
Status: Assigned (was: Untriaged)
The details marker needs to "opt-in" to get notifications on 'color' changes.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6017c24737b5e87c68936784b7c651b04127b1cf

commit 6017c24737b5e87c68936784b7c651b04127b1cf
Author: Fredrik Söderquist <fs@opera.com>
Date: Fri Sep 14 15:50:45 2018

Trigger paint invalidation for <detail> on 'color' changes

Much like a list marker, the details marker needs be added to the
"color changed" special case/optimization.

Bug:  883711 
Change-Id: Ib2237bd13887f4b5ff7fd2270bae6cb8654e0cd3
Reviewed-on: https://chromium-review.googlesource.com/1225875
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591354}
[add] https://crrev.com/6017c24737b5e87c68936784b7c651b04127b1cf/third_party/WebKit/LayoutTests/paint/invalidation/forms/details-marker-color-change-expected.html
[add] https://crrev.com/6017c24737b5e87c68936784b7c651b04127b1cf/third_party/WebKit/LayoutTests/paint/invalidation/forms/details-marker-color-change.html
[add] https://crrev.com/6017c24737b5e87c68936784b7c651b04127b1cf/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/forms/details-marker-color-change-expected.txt
[add] https://crrev.com/6017c24737b5e87c68936784b7c651b04127b1cf/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/forms/details-marker-color-change-expected.txt
[add] https://crrev.com/6017c24737b5e87c68936784b7c651b04127b1cf/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/forms/details-marker-color-change-expected.txt
[modify] https://crrev.com/6017c24737b5e87c68936784b7c651b04127b1cf/third_party/blink/renderer/core/layout/layout_object.cc

Status: Fixed (was: Assigned)
Labels: Target-71

Sign in to add a comment