"FileUtilTest.OpenFileNoInheritance" is flaky |
|||||
Issue description"FileUtilTest.OpenFileNoInheritance" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJGaWxlVXRpbFRlc3QuT3BlbkZpbGVOb0luaGVyaXRhbmNlDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 13
glibc is leaking this, which argues for a suppression.
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ba72f1b04fa80590ed084b29e5247906e87cdc9 commit 4ba72f1b04fa80590ed084b29e5247906e87cdc9 Author: Oskar Sundbom <ossu@chromium.org> Date: Thu Sep 13 15:43:25 2018 Remove character set from FileUtilTest.OpenFileNoInheritance on ASAN It has turned flaky. The failure looks like it could depend on the underlying C library used, since ASAN sometimes thinks it's leaking and sometimes don't. Bug: 883698 Change-Id: Ib76d9045bda77591172f0fb62914ba4054a12d90 Reviewed-on: https://chromium-review.googlesource.com/1224770 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#591026} [modify] https://crrev.com/4ba72f1b04fa80590ed084b29e5247906e87cdc9/base/files/file_util_unittest.cc
,
Sep 13
,
Sep 13
Actually, I'll reopen this one. Want to take a look if there's some better way of suppressing this specific ASan error before I close it.
,
Sep 13
It looks like the leak is still present in the glibc trunk, so you may want to file the leak with them too. They accept bug reports at https://sourceware.org/bugzilla/.
,
Sep 14
,
Sep 14
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ossu@chromium.org
, Sep 13Status: Assigned (was: Untriaged)
I get the following when running asan locally on the test: Direct leak of 208 byte(s) in 1 object(s) allocated from: #0 0xb93b73 in __interceptor_malloc _asan_rtl_:3 #1 0x7f0ca6447ea3 in __gconv_lookup_cache /tmp/build-debs.Lfl5zt/glibc-2.24/iconv/gconv_cache.c:372 #2 0x7f0ca6447ea3 in ?? ??:0 #2 0x61100015683f (<unknown module>) Direct leak of 208 byte(s) in 1 object(s) allocated from: #0 0xb93b73 in __interceptor_malloc _asan_rtl_:3 #1 0x7f0ca6447d43 in __gconv_lookup_cache /tmp/build-debs.Lfl5zt/glibc-2.24/iconv/gconv_cache.c:372 #2 0x7f0ca6447d43 in ?? ??:0 #2 0x616000002a7f (<unknown module>) SUMMARY: AddressSanitizer: 416 byte(s) leaked in 2 allocation(s). If I remove "r,ccs=UTF-8" from the list of modes tested, the problem goes away. That line was last changed in https://codereview.chromium.org/2731263002 Assigning to mark@, as he reviewed that one. Is this an error that should be suppressed, perhaps? Looks like it is outside of Chromium.