New issue
Advanced search Search tips

Issue 883687 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
AudioService-APM


Sign in to add a comment

AEC dump hits a sandbox trap when running APM in Audio Service on Linux

Project Member Reported by ossu@chromium.org, Sep 13

Issue description

I'm seeing some other issues with AEC dumps but this one looks specifically sandbox related. I'm just enabling debug recordings from chrome://webrtc-internals and then starting a meeting.

 ../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 0018
Received signal 11 SEGV_MAPERR 00000f070012
[77858:77865:0913/130856.119509:WARNING:render_delay_buffer.cc(420)] Applying internal delay of 5 blocks.
#0 0x7ffff7cec26d base::debug::StackTrace::StackTrace()
#1 0x7ffff79f39ac base::debug::StackTrace::StackTrace()[77858:77865:0913/130856.122148:WARNING:render_delay_buffer.cc(387)] Receiving a first reported externally buffer delay of 18 ms.

#2 0x7ffff7cebcc4 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fffd105f0c0 <unknown>
#4 0x7fffe1f4764c sandbox::CrashSIGSYS_Handler()
#5 0x7fffe1f4f42b sandbox::Trap::SigSys()
#6 0x7fffe1f4f0c2 sandbox::Trap::SigSysAction()
#7 0x7fffd105f0c0 <unknown>
#8 0x7fffd105e963 __GI_pwrite
#9 0x7ffff7cf8aa1 base::File::Write()
#10 0x7fffed3747c1 media::AudioDebugFileWriter::AudioFileWriter::WriteHeader()
#11 0x7fffed3742ed media::AudioDebugFileWriter::AudioFileWriter::StartRecording()
#12 0x7fffed37636e _ZN4base8internal13FunctorTraitsIMN5media20AudioDebugFileWriter15AudioFileWriterEFvNS_4FileEEvE6InvokeIS7_PS4_JS5_EEEvT_OT0_DpOT1_
#13 0x7fffed37628f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN5media20AudioDebugFileWriter15AudioFileWriterEFvNS_4FileEEJPS6_S7_EEEvOT_DpOT0_
#14 0x7fffed37621d _ZN4base8internal7InvokerINS0_9BindStateIMN5media20AudioDebugFileWriter15AudioFileWriterEFvNS_4FileEEJNS0_17UnretainedWrapperIS5_EES6_EEEFvvEE7RunImplIS8_NSt3__15tupleIJSA_S6_EEEJLm0ELm1EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
#15 0x7fffed376129 _ZN4base8internal7InvokerINS0_9BindStateIMN5media20AudioDebugFileWriter15AudioFileWriterEFvNS_4FileEEJNS0_17UnretainedWrapperIS5_EES6_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#16 0x7ffff79a23ee _ZNO4base12OnceCallbackIFvvEE3RunEv
#17 0x7ffff79f4f02 base::debug::TaskAnnotator::RunTask()
#18 0x7ffff7c0d3ac base::internal::TaskTracker::RunOrSkipTask()
#19 0x7ffff7d22d66 base::internal::TaskTrackerPosix::RunOrSkipTask()
#20 0x7ffff7c0b0e3 base::internal::TaskTracker::RunAndPopNextTask()
#21 0x7ffff7bf13a2 base::internal::SchedulerWorker::RunWorker()
#22 0x7ffff7bf0b2c base::internal::SchedulerWorker::RunPooledWorker()
#23 0x7ffff7bf0a4f base::internal::SchedulerWorker::ThreadMain()
#24 0x7ffff7d2404d base::(anonymous namespace)::ThreadFunc()
#25 0x7fffd1055494 start_thread
#26 0x7fffcceb1a8f clone
  r8: 000000000000e000  r9: 00007fffb8446a50 r10: 0000000000000001 r11: 0000000000000206
 r12: 0000000000000000 r13: 00007fffffff966f r14: 0000000000000000 r15: 00007ffff7ffd040
  di: 000000000f070012  si: 000000000f070012  bp: 00007fffb8445730  bx: 0000000000000000
  dx: fdbef24221866d00  ax: 000000000f070012  cx: 00007fffb84455b0  sp: 00007fffb8445700
  ip: 00007fffe1f4764c efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 000000000f070012
[end of stack trace]
Calling _exit(1). Core file will not be generated.


 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4552216de931e9e6c170da04cbc0e9595f844f00

commit 4552216de931e9e6c170da04cbc0e9595f844f00
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Thu Sep 13 18:54:34 2018

Allow pwrite syscalls in audio sandbox policy for debug recording.

Needed for audio service debug recording feature, that writes stream data to local
files for debug purposes. Debug recording files are created in browser process, and
file descriptors are passed to audio service process through mojo IPC.

Bug:  883687 
Change-Id: I0d932fa149a224f6ae1045c93f980c8479a7d28e
Reviewed-on: https://chromium-review.googlesource.com/1224532
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591094}
[modify] https://crrev.com/4552216de931e9e6c170da04cbc0e9595f844f00/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc

Status: Fixed (was: Started)
Labels: Merge-Request-70
Requesting merge to M70 to unblock APM experiment debugging, thank you.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 15

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2789570b8024b8f2f9a68d48a7adbbb50d7689b1

commit 2789570b8024b8f2f9a68d48a7adbbb50d7689b1
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Sat Sep 15 07:27:05 2018

Allow pwrite syscalls in audio sandbox policy for debug recording.

Needed for audio service debug recording feature, that writes stream data to local
files for debug purposes. Debug recording files are created in browser process, and
file descriptors are passed to audio service process through mojo IPC.

Bug:  883687 
Change-Id: I0d932fa149a224f6ae1045c93f980c8479a7d28e
Reviewed-on: https://chromium-review.googlesource.com/1224532
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591094}(cherry picked from commit 4552216de931e9e6c170da04cbc0e9595f844f00)
Reviewed-on: https://chromium-review.googlesource.com/1227074
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#434}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/2789570b8024b8f2f9a68d48a7adbbb50d7689b1/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc

Sign in to add a comment