Issue metadata
Sign in to add a comment
|
Popup menu options misaligned on changing the text size |
||||||||||||||||||||||||
Issue descriptionApp Version: 70.0.3538.13 beta iOS Version: 10.3.3, 11.4.1, 12.0 beta 12 Devices: iPhone 7 Plus, iPhone 6, iPhone 8 Plus Steps to reproduce: 1. Launch iOS Chrome 2. Enable ‘Larger Accessibility Sizes’ (Go to Device Settings>General>Accessibility>Larger Text) & Drag the slider to maximum 3. Long press on all Popup menus (Tools menu, Search button & Tab switcher button) Observed results: Popup menu items overlap and not aligned properly Note: Popup menu items get aligned only on app cold start Expected results: Popup menu items should be aligned properly and should support dynamic fonts Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on the current stable build :M69, Yes (No with Old UI, Yes with UI-Refresh) Bug reproducible on the current beta channel build :M70, Yes Type-bug-regression? No Link to Image/Video: https://drive.google.com/file/d/1-9islGK8X3SfISi7HvZvDq7AplqTrSaQ/view?usp=sharing
,
Oct 9
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d6a5359f3c467f4a8a52356568f4f6f48ca4ba3 commit 9d6a5359f3c467f4a8a52356568f4f6f48ca4ba3 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Oct 10 14:54:20 2018 [iOS] Adjust popup menus' items height on ContentSize changes This CL makes sure that the height of the popup menus' items is changing when the user is changing the preferred content size. Bug: 883685 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If0dc12cb8311108b023090a0e03800b214ce22d0 Reviewed-on: https://chromium-review.googlesource.com/c/1270956 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#598320} [modify] https://crrev.com/9d6a5359f3c467f4a8a52356568f4f6f48ca4ba3/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.h [modify] https://crrev.com/9d6a5359f3c467f4a8a52356568f4f6f48ca4ba3/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm [modify] https://crrev.com/9d6a5359f3c467f4a8a52356568f4f6f48ca4ba3/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h [modify] https://crrev.com/9d6a5359f3c467f4a8a52356568f4f6f48ca4ba3/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
,
Oct 10
,
Oct 16
Verified on 72.0.3582.0 Canary, iPhone X iOS 11.4.1, iPhone 7 iOS 12.0.1, https://drive.google.com/file/d/19N6esQc9-67GlT-K5gQg_-mYiSUk47nP/view
,
Oct 17
Verified on iPhoneX(iOS 11.4.1), iPhone 8plus(iOS 12.1 Beta) Popup menu options displays good as per the text size Link to video: https://drive.google.com/file/d/1VeuuN1dckTaknjGYsFRFP7sioPyllCQc/view?usp=sharing |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by thegreenfrog@chromium.org
, Sep 13Status: Assigned (was: Untriaged)