Audio playing speaker icon disappears in favor of the favicon when tab width reduces
Reported by
gilles.l...@lim.eu,
Sep 13
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0 Steps to reproduce the problem: 1. Open a tab playing audio 2. Open several other tabs, reducing their width What is the expected behavior? The audio playing icon in tab should always be visible What went wrong? The audio playing icon disappear when width becomes too small, showing the favicon instead of the speaker one. Did this work before? No Chrome version: 69.0.3497.81 (Official Build) (64-bit) Channel: stable OS Version: Debian jessie with stretch-backports 3.16.0-4-amd64 Flash Version: Shockwave Flash 26.0 r0 Same behavior (tested) in versions 68, 69 and 70. I thought it was a regression. Finding out which tab is playing sound is painful when you have a lot opened... I think the speaker (playing, not muted) icon should be displayed with a higher priority than the favicon.
,
Sep 13
,
Sep 14
Yeah, I decided not to fix this last time I touched the tab rendering, to avoid going too deep down the rabbit hole. The problem is the tab tires to figure out which icons it has room for, and when the tab gets that small it doesn't have enough room for any of them. So it gives up and just shows the favicon. I'm not exactly sure how the logic should take the audio indicator into account, since it's all really complicated already.
,
Sep 14
It might be easier to fix this if we first eliminate the separate function that computes icon visibility and do it all in layout. At that point, we can prioritize audio icon > favicon > everything else. The favicon will get auto-clipped at narrow widths so drawing it won't be a problem.
,
Sep 26
,
Sep 27
,
Sep 27
Triage: Yes, we should do this for M71.
,
Oct 8
Picking this up.
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84909ff6ee8c00b2fc314fbd401ed731dec9acac commit 84909ff6ee8c00b2fc314fbd401ed731dec9acac Author: Taylor Bergquist <tbergquist@chromium.org> Date: Tue Oct 09 02:08:31 2018 Show (and center) the alert icon on very narrow tabs. Tabs now fall back to showing the alert icon, if one is present, instead of the favicon when tabs are too narrow to fit any of their children. Bug: 883681 Change-Id: Ic7addc382b114cb75c59fdcffae912caf86a6f3c Reviewed-on: https://chromium-review.googlesource.com/c/1270180 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#597779} [modify] https://crrev.com/84909ff6ee8c00b2fc314fbd401ed731dec9acac/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/84909ff6ee8c00b2fc314fbd401ed731dec9acac/chrome/browser/ui/views/tabs/tab.h [modify] https://crrev.com/84909ff6ee8c00b2fc314fbd401ed731dec9acac/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Nov 20
***Mass UI Triage*** We were unable to reproduce this bug on latest canary #72.0.3616.0(Fix landed). If this bug still reproduces for you, please reopen or file a new issue. Thanks!
,
Dec 6
Indeed: I observe the expected behavior on 72.0.3626.7 dev (64-bit) :) Thanks! If the Fix has landed, the issue status should be "Fixed" instead of "WontFix" shouldn't it?
,
Dec 10
Yep, it would seem that I forgot to mark this as fixed after the above landed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by meh...@chromium.org
, Sep 13