FIP box is misaligned on relaunching in slide over mode. |
||||
Issue descriptionApp Version: 70.0.3538.13 beta iOS Version: iOS 10.3.3,11.4 Device: iPhone Air 2, iPad Mini 2, iPad Pro Steps to reproduce: 1. Launch Chrome. 2. Go to any website (say webmd.com) 3. Tap on Menu > Find in page 4. Send the app to background. 5. Relaunch chrome in Slide over mode. Observed results: FIP box is not aligned properly. Expected results: FIP box should be aligned properly Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA in M69 (New implementation on M70) Bug reproducible on the current beta channel build : New implementation in M70 Link to video/image: https://drive.google.com/file/d/1bbg3eu_QhHf0YnnBLq3xOmvZA13LxsgV/view?usp=sharing
,
Sep 17
Yi, could this be related to your latest changes?
,
Sep 18
I think yes, because I forbade the hide and reshow of findbar under IsUIRefreshPhase1Enabled. I will send a CL to fix this soon.
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92fdaae551a04d358aec5edbff75cf54f2a1cc30 commit 92fdaae551a04d358aec5edbff75cf54f2a1cc30 Author: Yi Su <mrsuyi@chromium.org> Date: Tue Oct 02 13:33:27 2018 Fix the bug that FIP box is misaligned on relaunching in slide over mode. If the device's size class has changed from RegularXRegular to another or reversely, the find bar should switch between regular mode and compact mode accordingly. Hide and then reshow the findbar in BVC.traitCollectionDidChange if the size class changed. Bug: 883672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38872c3fd0911e0e99ffae87f51f90c0cf9082fb Reviewed-on: https://chromium-review.googlesource.com/1256690 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595819} [modify] https://crrev.com/92fdaae551a04d358aec5edbff75cf54f2a1cc30/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/92fdaae551a04d358aec5edbff75cf54f2a1cc30/ios/chrome/browser/ui/uikit_ui_util.h [modify] https://crrev.com/92fdaae551a04d358aec5edbff75cf54f2a1cc30/ios/chrome/browser/ui/uikit_ui_util.mm
,
Oct 2
,
Oct 9
Verified in 71.0.3574.0 Canary in iPad 2018(iOS 11.4.1) and iPad mini(iOS 10.3.3) Fip box is not misaligned on relaunching in slide over mode Link to video: https://drive.google.com/file/d/1c4CwfKH3NQQciJ4ErE_hP3Yzjhs49II3/view?usp=sharing |
||||
►
Sign in to add a comment |
||||
Comment 1 by thegreenfrog@chromium.org
, Sep 13Status: Assigned (was: Untriaged)