New issue
Advanced search Search tips

Issue 883671 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Blink of unwanted scrollbar is seen when clicking outside of delete overlay in Files app

Project Member Reported by rkalavakuntla@chromium.org, Sep 13

Issue description

Chrome Version:69.0.3497.95/10895.56.0 beta channel Daisy,Kip,Celes
OS: chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Take a screenshot >>Show in folder >>click on delete icon
(2) Click on outside screen of Delete overlay and observe

Actual: Blink of unwanted scrollbar is seen
Expected: No such blink of unwanted scrollbar should be seen

This is a Regression issue as same is working fine in 66.0.3359.203/10452.103.0 stable

Note:Issue is seen from M-67

Attached the screencast for reference..


 
Actual.mp4
7.8 MB View Download
Expected.mp4
6.8 MB View Download
Labels: -M-69 CrOSFilesCategory-UI FoundIn-69
Status: Available (was: Untriaged)
Labels: Files-Fixit-2018
Owner: joelhockey@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53507168776107d351840a2f0067e5c372d98477

commit 53507168776107d351840a2f0067e5c372d98477
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Nov 19 06:20:29 2018

WebUI dialog: Pulse on container rather than frame

In FilesApp, we set |overflow: auto| on .cr-dialog-container to allow
scrolling on dialogs such as the chrome web store dialog which requires
scrolling to work on small screens.

The pulse event when a user clicks on .cr-dialog-container causes
the frame (dialog box) to increase in size by 2% for 180ms.
This is causing scrollbars to flash on during that time which
is not desirable.

By setting the pulse to increase the entire .cr-dialog-container
rather than just the frame, we get the same intended visual effect,
but without scrollbar flicker.

Bug:  883671 
Change-Id: I3fb75bef14059bc92b8baa2367290a16b0b0e08f
Reviewed-on: https://chromium-review.googlesource.com/c/1341432
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609185}
[modify] https://crrev.com/53507168776107d351840a2f0067e5c372d98477/ui/file_manager/file_manager/foreground/css/common.css
[modify] https://crrev.com/53507168776107d351840a2f0067e5c372d98477/ui/webui/resources/js/cr/ui/dialogs.js

Status: Fixed (was: Started)

Sign in to add a comment