New issue
Advanced search Search tips

Issue 883648 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 883330



Sign in to add a comment

Eliminate need for SigninManager::FromSigninManagerBase() once they're both hidden behind IdentityManager

Project Member Reported by blundell@chromium.org, Sep 13

Issue description

Currently, SigninManagerBase objects sometimes need to be downcast to SigninManager objects on non-ChromeOS platforms. We have added functionality to ensure that this downcast is always safe ( crbug.com/882441 ); however, it would still be much better to not require the downcasts at all. Once SigninManager and SigninManagerBase are hidden behind IdentityManager, we should be able to redesign them to avoid the need for these downcasts (which at that point would presumably be only in IdentityManager and related test infrastructure).
 

Sign in to add a comment