New issue
Advanced search Search tips

Issue 883642 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Sep 14
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Add specific metrics for share actions

Project Member Reported by gambard@chromium.org, Sep 13 
For now, when the user is using the share menu to do a Chrome action (ReadLater, bookmarks...), it is recorded as "MobileShareMenuGoogleUnknown". We should have specific recording for those actions.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa

commit 243bc7a0a211a164e9dfdb7df828864e2b0fa7aa
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Sep 14 10:52:06 2018

[iOS] Add snackbar for the copy action

This CL adds a snackbar for the copy action from the share menu.
It also consolidates metrics for the different actions of the share
menu.

Bug:  880030 ,  883642 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9ad39ad2f4f9b34e4d26aacc12a9db1fb2364bb6
Reviewed-on: https://chromium-review.googlesource.com/1224311
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591320}
[modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm
[modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm
[modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm
[modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activity_type_util.h
[modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/ios/chrome/browser/ui/activity_services/activity_type_util.mm
[modify] https://crrev.com/243bc7a0a211a164e9dfdb7df828864e2b0fa7aa/tools/metrics/actions/actions.xml

Comment 2 by gambard@chromium.org, Sep 14

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36861adff6ca785c012d45eae124987eda160645

commit 36861adff6ca785c012d45eae124987eda160645
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Sep 17 15:18:06 2018

[iOS] Add snackbar for the copy action

This CL adds a snackbar for the copy action from the share menu.
It also consolidates metrics for the different actions of the share
menu.

Bug:  880030 ,  883642 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9ad39ad2f4f9b34e4d26aacc12a9db1fb2364bb6
Reviewed-on: https://chromium-review.googlesource.com/1224311
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591320}(cherry picked from commit 243bc7a0a211a164e9dfdb7df828864e2b0fa7aa)
Reviewed-on: https://chromium-review.googlesource.com/1228196
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#446}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm
[modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm
[modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm
[modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activity_type_util.h
[modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/ios/chrome/browser/ui/activity_services/activity_type_util.mm
[modify] https://crrev.com/36861adff6ca785c012d45eae124987eda160645/tools/metrics/actions/actions.xml
►

Sign in to add a comment