New issue
Advanced search Search tips

Issue 883641 link

Starred by 1 user
Status: Verified
Owner:
machenb...@chromium.org
Closed: Sep 13
Cc:
bpastene@chromium.org
yangguo@chromium.org
jbudorick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 881910



Sign in to add a comment

V8 deps roll broken: https://crrev.com/c/1223426

Project Member Reported by machenb...@chromium.org, Sep 13 
Error:
https://ci.chromium.org/p/v8/builders/luci.v8.try/v8_linux64_rel_ng/b8935516599910820608

ERROR at //build/config/arm.gni:6:1: Can't load input file.
import("//third_party/catapult/devil/devil_arm.gni")
^--------------------------------------------------
Unable to load:
  /b/swarming/w/ir/cache/builder/v8/third_party/catapult/devil/devil_arm.gni
I also checked in the secondary tree for:
  /b/swarming/w/ir/cache/builder/v8/build/secondary/third_party/catapult/devil/devil_arm.gni
See //BUILD.gn:6:1: whence it was imported.
import("//build/config/arm.gni")
^------------------------------
GN gen failed: 1


Seems to be caused by:
https://crrev.com/c/1221727

Comment 1 by machenb...@chromium.org, Sep 13

Owner: machenb...@chromium.org
Status: Started (was: Untriaged)
It appears that until now, V8 only includes catapult in android checkouts:
https://cs.chromium.org/chromium/src/v8/DEPS?q=DEPS&sq=package:chromium&dr=C&l=35

The file also seems to be needed on an arm code path, but is not guarded behind some is_android condition.

Lets sync catapult unconditionally like chromium does...

Comment 2 by machenb...@chromium.org, Sep 13 

Piggybacking this onto https://crrev.com/c/1223426 patch 2

Comment 3 by machenb...@chromium.org, Sep 13

Cc: yangguo@chromium.org
Also requires to add catapult to V8's node.js integration. Done in https://crrev.com/c/1223426 patch 3.

Comment 4 by machenb...@chromium.org, Sep 13

Status: Verified (was: Started)
►

Sign in to add a comment