This is an OOM while trying to add code to the module:

v8::internal::V8::FatalProcessOutOfMemory(...)
v8::internal::wasm::NativeModule::AddOwnedCode(...)
v8::internal::wasm::NativeModule::AddCode(...)
v8::internal::wasm::LiftoffCompilationUnit::ExecuteCompilation()
v8::internal::wasm::WasmCompilationUnit::ExecuteCompilation()
v8::internal::wasm::`anonymous namespace'::FetchAndExecuteCompilationUnit

We have a total limit of 512MB of wasm code per wasm engine (i.e. process-wide): https://cs.chromium.org/chromium/src/v8/src/wasm/wasm-code-manager.cc?l=783

If this is not enough for the users, these are the options we have:
1) [users] Shrink your modules (if possible).
2) [v8] Implement garbage collection for wasm code (might not even help, and takes time).
3) [v8] Switch to lazy compilation for wasm modules (not what we want).
4) [v8] Increase the code space limit further (to 1GB?).

Thanks for your help Clemens :) Just to confirm, the total committed code space per wasm engine in my context would be the total size of the main and two side modules?

I don’t think I would be able to shrink my module. In fact, it would grow larger with time. If we were to pursue option (4) e.g. increase code space limit to 1GB, is this a decision that can be undertaken by the Chrome team internally? FYI, FF is able to support my use case here.

Yes, total committed code space includes all modules compiled in the same renderer process, so in your case it's the main module and all side modules.

And yes, we can make this decision internally. I would like to get an opinion on option 4 from Thomas Nattestad (PM on v8 and wasm) and Chris Palmer (security expert).

Long term, I also expect modules to grow bigger, so options 1-3 would just buy us some time.
Option 2 will be implemented anyway, but in this case I am not sure if it would help, since all Liftoff code might be live at the same time, so there might be nothing to garbage-collect.

FYI: Unity has the same issue (see issue 872684).

Correction: issue 872684 is about the Unreal engine, not Unity.

This bug probably affects all platforms, except iOS where we don't have control. But I'll let you all check the OS boxes if you agree.

I think we have to live with increasing the limit, as we already have for the overall address space/memory limits. See https://bugs.chromium.org/p/chromium/issues/detail?id=853873 for more info. One thing I'd like to do is to keep the limits as harmonized as possible across platforms; I don't want lots of special cases for each platform.

Issue 884039 has been merged into this issue.

This affects at least the platforms where we ship Liftoff. Given that the size of wasm modules is generally increasing, it might affect more platforms, but not that urgently.

I propose to increase the limit on all platforms, per this CL: https://crrev.com/c/1226971

The only exception currently is arm64, where for technical reason we have to limit the code to 128MB. Since this is too little for most of today's demos, this is something we have to address anyway.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/778460368740dc5f2e094813485394e1009bea0e

commit 778460368740dc5f2e094813485394e1009bea0e
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Sep 17 08:30:58 2018

[wasm] Run GC if page allocation fails, then retry

This adds another instance of the "if allocation fails, run GC then
retry" pattern, this time for making the actual memory reservation for
wasm memory.

R=mlippautz@chromium.org

Bug:  chromium:883639 ,  v8:7872 ,  v8:8158 
Change-Id: I40ed020ed2bbc253c4bbcbe51e3e9f5a0278d7a1
Reviewed-on: https://chromium-review.googlesource.com/1227117
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55936}
[modify] https://crrev.com/778460368740dc5f2e094813485394e1009bea0e/src/wasm/wasm-code-manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/863e6ce90e0f63a2bdc34be9043d22ebac450962

commit 863e6ce90e0f63a2bdc34be9043d22ebac450962
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Sep 17 11:59:50 2018

[wasm] Fix flaky OOM on memory allocation

We still see occasions of "WebAssembly Instantiation: Out of memory:
wasm memory", e.g. on the N5X arm64 bot.

We already have a retry-loop around the {ReserveAddressSpace} call, so
this error can only happen if {AllocatePages} fails.
I cannot easily reproduce, so I will land this CL and hope that it
fixes the flake.

We might eventually replace all these gc-then-retry loops by a better
mechanism which knows about process-wide allocations. Currently,
{AllocatePages} is isolate-independent, and only calls
{Platform::OnCriticalMemoryPressure}, but this call does nothing on the
default platform. So trigger a GC on the current isolate instead.

R=mlippautz@chromium.org

Bug:  chromium:883639 ,  v8:7872 ,  v8:8158 
Change-Id: Ib4e4a4a5f6b598d5832c327b1fc83ccb3bada9bc
Reviewed-on: https://chromium-review.googlesource.com/1226886
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55955}
[modify] https://crrev.com/863e6ce90e0f63a2bdc34be9043d22ebac450962/src/wasm/wasm-memory.cc

Clemens, are there any updates on this issue? Thanks.

I am trying to land this CL to increase the code space limit: https://crrev.com/c/1226971
It currently fails on win64, I am investigating this.

If this all works out, we will try to merge this to M-70, and maybe also to M-69.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c8fe898dd83c100bdd8263426b9baa7c66a5083f

commit c8fe898dd83c100bdd8263426b9baa7c66a5083f
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Sep 18 16:07:45 2018

[wasm] Track code reservations in the WasmMemoryTracker

The WasmMemoryTracker keeps track of reserved memory in order to avoid
running out of virtual address space. So far, we were only tracking
reservations for wasm memory, and not for code. This CL changes that to
also include code reservations.

Drive-by: Some cleanup around the allocation of the WasmCodeManager.

R=titzer@chromium.org

Bug:  chromium:883639 
Change-Id: I0c2586a742022ae00752132e048346d54e2a1a7c
Reviewed-on: https://chromium-review.googlesource.com/1230134
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56001}
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/src/wasm/wasm-engine.cc
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/src/wasm/wasm-engine.h
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/src/wasm/wasm-memory.cc
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/src/wasm/wasm-memory.h
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/test/cctest/wasm/test-wasm-shared-engine.cc
[modify] https://crrev.com/c8fe898dd83c100bdd8263426b9baa7c66a5083f/test/unittests/wasm/wasm-code-manager-unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/15d6d7b4eeea65836b48340bfd73b5ff0df1061c

commit 15d6d7b4eeea65836b48340bfd73b5ff0df1061c
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Tue Sep 18 16:34:55 2018

[wasm] Increase code space limit to 1024 MB

Liftoff increases code size, and people start deploying bigger modules.
Increase the wasm code space limit from 512 MB to 1024 MB to account
for this.

R=titzer@chromium.org

Bug:  chromium:883639 , chromium:872684
Change-Id: I3a2ca29d456635f7f3aa1daef5fa2b0249dc1645
Reviewed-on: https://chromium-review.googlesource.com/1226971
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56003}
[modify] https://crrev.com/15d6d7b4eeea65836b48340bfd73b5ff0df1061c/src/globals.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/68b36a153cc20327c755feb3338ccdd1ace9ba7d

commit 68b36a153cc20327c755feb3338ccdd1ace9ba7d
Author: Yang Guo <yangguo@chromium.org>
Date: Wed Sep 19 08:02:51 2018

Revert "[wasm] Increase code space limit to 1024 MB"

This reverts commit 15d6d7b4eeea65836b48340bfd73b5ff0df1061c.

Reason for revert: speculative revert for this failure: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8934981003100286416/+/steps/Check/0/logs/Fixed/0

Original change's description:
> [wasm] Increase code space limit to 1024 MB
> 
> Liftoff increases code size, and people start deploying bigger modules.
> Increase the wasm code space limit from 512 MB to 1024 MB to account
> for this.
> 
> R=​titzer@chromium.org
> 
> Bug:  chromium:883639 , chromium:872684
> Change-Id: I3a2ca29d456635f7f3aa1daef5fa2b0249dc1645
> Reviewed-on: https://chromium-review.googlesource.com/1226971
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Ben Titzer <titzer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56003}

TBR=titzer@chromium.org,clemensh@chromium.org

Change-Id: I77b3eb694edef122fb3467ca1938c5aff833911d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:883639 , chromium:872684
Reviewed-on: https://chromium-review.googlesource.com/1232958
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56014}
[modify] https://crrev.com/68b36a153cc20327c755feb3338ccdd1ace9ba7d/src/globals.h

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/baa9bf19ef46c422ba3e106859be62183afcc8b8

commit baa9bf19ef46c422ba3e106859be62183afcc8b8
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Wed Sep 19 10:20:09 2018

Reland "[wasm] Increase code space limit to 1024 MB"

This is a reland of 15d6d7b4eeea65836b48340bfd73b5ff0df1061c.

Original change's description:
> [wasm] Increase code space limit to 1024 MB
>
> Liftoff increases code size, and people start deploying bigger modules.
> Increase the wasm code space limit from 512 MB to 1024 MB to account
> for this.
>
> R=titzer@chromium.org
>
> Bug:  chromium:883639 , chromium:872684
> Change-Id: I3a2ca29d456635f7f3aa1daef5fa2b0249dc1645
> Reviewed-on: https://chromium-review.googlesource.com/1226971
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Reviewed-by: Ben Titzer <titzer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#56003}

TBR=titzer@chromium.org

Bug:  chromium:883639 , chromium:872684
Change-Id: I54461d2a5f32eeaf90c71768eb9f37223dd5ebb6
Reviewed-on: https://chromium-review.googlesource.com/1233256
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56025}
[modify] https://crrev.com/baa9bf19ef46c422ba3e106859be62183afcc8b8/src/globals.h

This is contained in the last two canaries (>=71.0.3556.0), and looking good so far.

Backmerge to 7.0 works with very minor manual merges: https://crrev.com/c/1236258
Requesting this backmerge.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Just tried, we could even merge back to M-69. Michael (hablich@), what's your opinion on that?

Approving merge to M70. 

As this is a regression fix that has severe impact on a few customers, let's merge it back to 69.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4b62d43f22ac5de5cecf276de12f9d56f5774e47

commit 4b62d43f22ac5de5cecf276de12f9d56f5774e47
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Sep 21 09:27:32 2018

Merged: Increase wasm code space limit (squashed multiple commits)

Merged: [wasm] Run GC if page allocation fails, then retry
Reviewed-on: https://chromium-review.googlesource.com/1227117

Merged: [wasm] Fix flaky OOM on memory allocation
Reviewed-on: https://chromium-review.googlesource.com/1226886

Merged: [wasm] Track code reservations in the WasmMemoryTracker
Reviewed-on: https://chromium-review.googlesource.com/1230134

Merged: [wasm] Increase code space limit to 1024 MB
Reviewed-on: https://chromium-review.googlesource.com/1226971

R=ahaas@chromium.org

Bug:  chromium:883639 
Change-Id: I4bc4f5ac92f62ef48028f1935bb3562e97967d74
No-Try: true
No-Presubmit: true
No-Treechecks: true
Reviewed-on: https://chromium-review.googlesource.com/1238174
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#41}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424}
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/globals.h
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/wasm/wasm-engine.cc
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/wasm/wasm-engine.h
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/wasm/wasm-memory.cc
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/src/wasm/wasm-memory.h
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/test/cctest/wasm/test-wasm-shared-engine.cc
[modify] https://crrev.com/4b62d43f22ac5de5cecf276de12f9d56f5774e47/test/unittests/wasm/wasm-code-manager-unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a

commit bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Sep 21 11:16:05 2018

Merged: Increase wasm code space limit (squashed multiple commits)

Merged: [wasm] Run GC if page allocation fails, then retry
Reviewed-on: https://chromium-review.googlesource.com/1227117

Merged: [wasm] Fix flaky OOM on memory allocation
Reviewed-on: https://chromium-review.googlesource.com/1226886

Merged: [wasm] Track code reservations in the WasmMemoryTracker
Reviewed-on: https://chromium-review.googlesource.com/1230134

Merged: [wasm] Increase code space limit to 1024 MB
Reviewed-on: https://chromium-review.googlesource.com/1226971

R=ahaas@chromium.org

Bug:  chromium:883639 
Change-Id: I9e9e4922fe7a870a177852d9c21561ea3b78dc1b
No-Try: true
No-Presubmit: true
No-Treechecks: true
Reviewed-on: https://chromium-review.googlesource.com/1238213
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.9@{#54}
Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/globals.h
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/isolate.cc
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/wasm/wasm-engine.cc
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/wasm/wasm-engine.h
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/wasm/wasm-memory.cc
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/src/wasm/wasm-memory.h
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/test/cctest/wasm/test-wasm-shared-engine.cc
[modify] https://crrev.com/bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a/test/unittests/wasm/wasm-code-manager-unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c59e505b7107d93337a9824be3a0873f55a0ad49

commit c59e505b7107d93337a9824be3a0873f55a0ad49
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Sep 21 17:05:56 2018

Revert "Merged: Increase wasm code space limit (squashed multiple commits)"

This reverts commit bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a.

Reason for revert: Fails on ia32: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20stable%20branch%20-%20debug/416
Fix is to merge back one more change. Will do that on Monday.

Original change's description:
> Merged: Increase wasm code space limit (squashed multiple commits)
> 
> Merged: [wasm] Run GC if page allocation fails, then retry
> Reviewed-on: https://chromium-review.googlesource.com/1227117
> 
> Merged: [wasm] Fix flaky OOM on memory allocation
> Reviewed-on: https://chromium-review.googlesource.com/1226886
> 
> Merged: [wasm] Track code reservations in the WasmMemoryTracker
> Reviewed-on: https://chromium-review.googlesource.com/1230134
> 
> Merged: [wasm] Increase code space limit to 1024 MB
> Reviewed-on: https://chromium-review.googlesource.com/1226971
> 
> R=​ahaas@chromium.org
> 
> Bug:  chromium:883639 
> Change-Id: I9e9e4922fe7a870a177852d9c21561ea3b78dc1b
> No-Try: true
> No-Presubmit: true
> No-Treechecks: true
> Reviewed-on: https://chromium-review.googlesource.com/1238213
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/branch-heads/6.9@{#54}
> Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
> Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}

TBR=ahaas@chromium.org,clemensh@chromium.org

Change-Id: I2df3c64f32f4a0cec1866e246c2768ce2c184781
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:883639 
Reviewed-on: https://chromium-review.googlesource.com/1239073
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.9@{#56}
Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/globals.h
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/isolate.cc
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/wasm/wasm-engine.cc
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/wasm/wasm-engine.h
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/wasm/wasm-memory.cc
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/src/wasm/wasm-memory.h
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/test/cctest/wasm/test-wasm-shared-engine.cc
[modify] https://crrev.com/c59e505b7107d93337a9824be3a0873f55a0ad49/test/unittests/wasm/wasm-code-manager-unittest.cc

Had to revert the merge to 6.9.
Reland CL here: https://crrev.com/c/1239074
It's only a minor modification, but given that this is a merge to the stable branch I will wait for explicit LGTM on the CL.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4250e26ef582d42ebdd467720bfe57dafb013d09

commit 4250e26ef582d42ebdd467720bfe57dafb013d09
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Mon Sep 24 12:31:44 2018

Reland "Merged: Increase wasm code space limit (squashed multiple commits)"

This is a reland of bd50488cf1a04d1f47b0ed7eb9d0e940ed9b529a.
One change from https://crrev.com/c/1112003 was merged into this CL to fix
the DCHECK failures.

Original change's description:
> Merged: Increase wasm code space limit (squashed multiple commits)
>
> Merged: [wasm] Run GC if page allocation fails, then retry
> Reviewed-on: https://chromium-review.googlesource.com/1227117
>
> Merged: [wasm] Fix flaky OOM on memory allocation
> Reviewed-on: https://chromium-review.googlesource.com/1226886
>
> Merged: [wasm] Track code reservations in the WasmMemoryTracker
> Reviewed-on: https://chromium-review.googlesource.com/1230134
>
> Merged: [wasm] Increase code space limit to 1024 MB
> Reviewed-on: https://chromium-review.googlesource.com/1226971
>
> R=ahaas@chromium.org
>
> Bug:  chromium:883639 
> Change-Id: I9e9e4922fe7a870a177852d9c21561ea3b78dc1b
> No-Try: true
> No-Presubmit: true
> No-Treechecks: true
> Reviewed-on: https://chromium-review.googlesource.com/1238213
> Reviewed-by: Andreas Haas <ahaas@chromium.org>
> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
> Cr-Commit-Position: refs/branch-heads/6.9@{#54}
> Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
> Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}

Bug:  chromium:883639 
No-Try: true
No-Presubmit: true
No-Treechecks: true
Change-Id: Idc53309e8670327e6845065c854ecd08dccea8a9
Reviewed-on: https://chromium-review.googlesource.com/1239074
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Ben Titzer <titzer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.9@{#58}
Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/globals.h
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/isolate.cc
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/wasm/wasm-engine.cc
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/wasm/wasm-engine.h
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/wasm/wasm-memory.cc
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/src/wasm/wasm-memory.h
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/test/cctest/wasm/test-wasm-shared-engine.cc
[modify] https://crrev.com/4250e26ef582d42ebdd467720bfe57dafb013d09/test/unittests/wasm/wasm-code-manager-unittest.cc

Not needed for Node.js 10.x (V8 6.8) AFAICT.