New issue
Advanced search Search tips

Issue 883628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Photo backup functionality doesn't have any test coverage

Project Member Reported by dats@chromium.org, Sep 13

Issue description

Javascript tests are missing for this. They would need some simulation of USB sticks mounting with "DCIM" folder and dealing with legacy Drive sync client to handle metadata searches.
 
Cc: noel@chromium.org
Labels: CrOSFilesCategory-Testing
Owner: sa...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ce6a168d6915d5fa5068a0682bb663830eca70

commit 57ce6a168d6915d5fa5068a0682bb663830eca70
Author: Sam McNally <sammc@chromium.org>
Date: Wed Sep 19 03:12:17 2018

Add an integration test for backing up photos to Drive.

In order to make the test pass:
- Change chrome.fileManagerPrivate.setEntryTag() to succeed but take no
  other action with DriveFS enabled; it won't be supported with DriveFS.
- Enable a mock SyncFileSystemService so the use of the syncFileSystem
  API can succeed locally.
- Add support for mounting a USB drive containing a DCIM directory with
  an image.

This test only exercises basic functionality:
- There is no previous photo backup history in the syncFileSystem.
- Images in the external drive are not duplicated in Drive.

Bug:  883628 
Change-Id: Ic5244de54bdd6f3fee0c82a356e7e530b85dba64
Reviewed-on: https://chromium-review.googlesource.com/1230193
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592313}
[modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/ui/file_manager/integration_tests/file_manager/drive_specific.js

Status: Fixed (was: Assigned)

Sign in to add a comment