Photo backup functionality doesn't have any test coverage |
||
Issue descriptionJavascript tests are missing for this. They would need some simulation of USB sticks mounting with "DCIM" folder and dealing with legacy Drive sync client to handle metadata searches.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bb8ab89b6e09f59380973531d04b4c67c172c0e commit 0bb8ab89b6e09f59380973531d04b4c67c172c0e Author: Sam McNally <sammc@chromium.org> Date: Tue Sep 18 23:09:46 2018 Migrate some directory tree test helpers into remote_call.js Bug: 883628 Change-Id: I5f4d81dd1a1d269a33091748def79d20941f1eca Reviewed-on: https://chromium-review.googlesource.com/1229638 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592247} [modify] https://crrev.com/0bb8ab89b6e09f59380973531d04b4c67c172c0e/ui/file_manager/integration_tests/file_manager/create_new_folder.js [modify] https://crrev.com/0bb8ab89b6e09f59380973531d04b4c67c172c0e/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js [modify] https://crrev.com/0bb8ab89b6e09f59380973531d04b4c67c172c0e/ui/file_manager/integration_tests/remote_call.js
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57ce6a168d6915d5fa5068a0682bb663830eca70 commit 57ce6a168d6915d5fa5068a0682bb663830eca70 Author: Sam McNally <sammc@chromium.org> Date: Wed Sep 19 03:12:17 2018 Add an integration test for backing up photos to Drive. In order to make the test pass: - Change chrome.fileManagerPrivate.setEntryTag() to succeed but take no other action with DriveFS enabled; it won't be supported with DriveFS. - Enable a mock SyncFileSystemService so the use of the syncFileSystem API can succeed locally. - Add support for mounting a USB drive containing a DCIM directory with an image. This test only exercises basic functionality: - There is no previous photo backup history in the syncFileSystem. - Images in the external drive are not duplicated in Drive. Bug: 883628 Change-Id: Ic5244de54bdd6f3fee0c82a356e7e530b85dba64 Reviewed-on: https://chromium-review.googlesource.com/1230193 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592313} [modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc [modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/57ce6a168d6915d5fa5068a0682bb663830eca70/ui/file_manager/integration_tests/file_manager/drive_specific.js
,
Oct 5
|
||
►
Sign in to add a comment |
||
Comment 1 by sa...@chromium.org
, Sep 13Labels: CrOSFilesCategory-Testing
Owner: sa...@chromium.org
Status: Assigned (was: Untriaged)