New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 883624 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Sep 13
Cc:
ossu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"MessageTest.SerializeSimpleMessageWithHandlesWithContext" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Sep 13 
"MessageTest.SerializeSimpleMessageWithHandlesWithContext" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhNZXNzYWdlVGVzdC5TZXJpYWxpemVTaW1wbGVNZXNzYWdlV2l0aEhhbmRsZXNXaXRoQ29udGV4dAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by ossu@chromium.org, Sep 13

Cc: ossu@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
This test seems flaky on fuchsia_x64. Example test output:

[ RUN      ] MessageTest.SerializeSimpleMessageWithHandlesWithContext
[39445:91104371:0827/134258.589758:21247363:WARNING:test_suite.cc(258)] Test launcher output path /tmp/.org.chromium.Chromium.aMeGpE/test_results.xml exists. Not adding test launcher result printer.
[37901:457848361:0827/134258.638735:21296336:FATAL:mojo_test_base.cc(134)] Check failed: MOJO_RESULT_OK == ReadMessageRaw(MessagePipeHandle(mp), &bytes, &handles, ((uint32_t)0)) (0 vs. 9)
bt#00: pc 0x7d8ba59fe9e1 (app:/pkg/bin/app,0x4a09e1)
bt#01: pc 0x7d8ba598e5f0 (app:/pkg/bin/app,0x4305f0)
bt#02: pc 0x7d8ba5a72245 (app:/pkg/bin/app,0x514245)
bt#03: pc 0x7d8ba5a7252d (app:/pkg/bin/app,0x51452d)
bt#04: pc 0x7d8ba572de90 (app:/pkg/bin/app,0x1cfe90)
bt#05: pc 0x7d8ba58b29b7 (app:/pkg/bin/app,0x3549b7)
bt#06: pc 0x7d8ba58b3085 (app:/pkg/bin/app,0x355085)
bt#07: pc 0x7d8ba58b33bc (app:/pkg/bin/app,0x3553bc)
bt#08: pc 0x7d8ba58b9009 (app:/pkg/bin/app,0x35b009)
bt#09: pc 0x7d8ba58b8dbf (app:/pkg/bin/app,0x35adbf)
bt#10: pc 0x7d8ba5a1c0d4 (app:/pkg/bin/app,0x4be0d4)
bt#11: pc 0x7d8ba578d5da (app:/pkg/bin/app,0x22f5da)
bt#12: pc 0x7d8ba5a2023a (app:/pkg/bin/app,0x4c223a)
bt#13: pc 0x7d8ba5a1f536 (app:/pkg/bin/app,0x4c1536)
bt#14: pc 0x7d8ba5a1f3e8 (app:/pkg/bin/app,0x4c13e8)
bt#15: pc 0x7d8ba578d4ec (app:/pkg/bin/app,0x22f4ec)
bt#16: pc 0x6baa0cabfb8f (libasync-default.so,0x19a914751b8f)
bt#17: end

Assigning to rockot@, will disable on fuchsia for now.

Comment 2 by ossu@chromium.org, Sep 13

Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a41a63d0677b05f4d46257b3f659ee39a721e3

commit b9a41a63d0677b05f4d46257b3f659ee39a721e3
Author: Oskar Sundbom <ossu@chromium.org>
Date: Thu Sep 13 13:57:12 2018

Disabling MessageTest.SerializeSimpleMessageWithHandlesWithContext on Fuchsia

It's been flaky for a long time. Older logs don't show any output, so
I'm unsure if this problem has permuted, or if the logs have just atrophied.

Bug:  883624 
Tbr: rockot@chromium.org
Change-Id: Ia9809a38d97730d0a30ab7e2250140d64cde8f46
Reviewed-on: https://chromium-review.googlesource.com/1224439
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590996}
[modify] https://crrev.com/b9a41a63d0677b05f4d46257b3f659ee39a721e3/mojo/core/message_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d341047ba88ca02e3e66ba955c798669040f781e

commit d341047ba88ca02e3e66ba955c798669040f781e
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Sep 13 21:36:59 2018

[mojo] Fix test flake

Adds a missing synchronization step to the end of some multiprocess
tests to ensure that client process termination does not race with IPC
events.

Bug:  883624 
Change-Id: I91f4dd0d8b28469ff8da60714367d423e1e308fb
Reviewed-on: https://chromium-review.googlesource.com/1225604
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591169}
[modify] https://crrev.com/d341047ba88ca02e3e66ba955c798669040f781e/mojo/core/message_unittest.cc

Comment 5 by roc...@chromium.org, Sep 13

Status: Fixed (was: Assigned)
Should be no more flake now. Test re-enabled for Fuchsia.
►

Sign in to add a comment