graphics_VideoRenderingPower regression |
|||
Issue descriptionWe have an alert/regression here https://crosland.corp.google.com/log/11048.0.0..11051.0.0 probably due to https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1208899/3/client/cros/power/power_utils.py Need to restore "None" now. ERROR graphics_VideoRenderingPower graphics_VideoRenderingPower timestamp=1536720890 localtime=Sep 11 19:54:50 Unhandled TypeError: %d format: a number is required, not NoneType Traceback (most recent call last): File "/usr/local/autotest/common_lib/test.py", line 634, in _exec _cherry_pick_call(self.cleanup, *args, **dargs) File "/usr/local/autotest/common_lib/test.py", line 715, in _cherry_pick_call return func(*p_args, **p_dargs) File "/usr/local/autotest/tests/graphics_VideoRenderingPower/graphics_VideoRenderingPower.py", line 58, in cleanup self._backlight.restore() File "/usr/local/autotest/cros/power/power_utils.py", line 409, in restore self.set_level(self._init_level) File "/usr/local/autotest/cros/power/power_utils.py", line 352, in set_level self._try_bl_cmd('--set_brightness=%d' % (level)) TypeError: %d format: a number is required, not NoneType
,
Sep 13
fix is here crrev.com/c/1222257
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/af966ae99beb1a9077a8c6e8be180bbf36739b0e commit af966ae99beb1a9077a8c6e8be180bbf36739b0e Author: Todd Broch <tbroch@chromium.org> Date: Fri Sep 14 19:08:49 2018 power_utils: Don't restore backlight level if it can't be set. BUG=b:113822847, chromium:883612 TEST=power_Idle & video_JDAPerf No longer see typeError exception. Change-Id: Id1e8327b17829417a134b367c3b6df248de577e0 Reviewed-on: https://chromium-review.googlesource.com/1222257 Commit-Ready: Todd Broch <tbroch@chromium.org> Tested-by: Todd Broch <tbroch@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Hsu Wei-Cheng <mojahsu@chromium.org> [modify] https://crrev.com/af966ae99beb1a9077a8c6e8be180bbf36739b0e/client/cros/power/power_utils.py
,
Sep 17
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ihf@chromium.org
, Sep 13